From d28c2986d69141280fce64ac5603b107512f8771 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 18 Nov 2010 00:11:32 +0000 Subject: Eliminate SET_NB_CFG_54 option. There was no board that deselected it, and very likely there won't ever be any hardware that requires it deselected. Keep the "selected" code path around, leading to no functional change. Signed-off-by: Patrick Georgi Acked-by: Scott Duplichan git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6086 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/cpu/amd/dualcore/dualcore.c | 11 ----------- src/cpu/amd/quadcore/quadcore.c | 11 ----------- 2 files changed, 22 deletions(-) (limited to 'src/cpu') diff --git a/src/cpu/amd/dualcore/dualcore.c b/src/cpu/amd/dualcore/dualcore.c index b1894ce154..5206b07644 100644 --- a/src/cpu/amd/dualcore/dualcore.c +++ b/src/cpu/amd/dualcore/dualcore.c @@ -1,10 +1,5 @@ /* 2004.12 yhlu add dual core support */ - -#ifndef SET_NB_CFG_54 - #define SET_NB_CFG_54 1 -#endif - #include "cpu/amd/dualcore/dualcore_id.c" #include #if CONFIG_HAVE_OPTION_TABLE @@ -20,7 +15,6 @@ static inline unsigned get_core_num_in_bsp(unsigned nodeid) return dword; } -#if SET_NB_CFG_54 == 1 static inline uint8_t set_apicid_cpuid_lo(void) { #if CONFIG_K8_REV_F_SUPPORT == 0 @@ -35,11 +29,6 @@ static inline uint8_t set_apicid_cpuid_lo(void) return 1; } -#else - -static inline void set_apicid_cpuid_lo(void) { } - -#endif static inline void real_start_other_core(unsigned nodeid) { diff --git a/src/cpu/amd/quadcore/quadcore.c b/src/cpu/amd/quadcore/quadcore.c index 3e5c197157..e7d9c7be3f 100644 --- a/src/cpu/amd/quadcore/quadcore.c +++ b/src/cpu/amd/quadcore/quadcore.c @@ -24,10 +24,6 @@ #include "option_table.h" #endif -#ifndef SET_NB_CFG_54 - #define SET_NB_CFG_54 1 -#endif - #include "cpu/amd/quadcore/quadcore_id.c" static u32 get_core_num_in_bsp(u32 nodeid) @@ -43,7 +39,6 @@ static u32 get_core_num_in_bsp(u32 nodeid) return dword; } -#if SET_NB_CFG_54 == 1 static u8 set_apicid_cpuid_lo(void) { // set the NB_CFG[54]=1; why the OS will be happy with that ??? @@ -54,12 +49,6 @@ static u8 set_apicid_cpuid_lo(void) return 1; } -#else - -static void set_apicid_cpuid_lo(void) { } - -#endif - static void real_start_other_core(u32 nodeid, u32 cores) { -- cgit v1.2.3