From 80fb8edaea44483ed9fa28bfe060734d771150aa Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Wed, 5 Nov 2014 10:28:28 +0100 Subject: acpigen: Add and use acpigen_write_method. The sequence of bytes to create a method is used several times in codebase. Put it into a function with logical arguments rather than duplicating magic bytes everywhere. Change-Id: I0e55d8dc7d5e8e92a521c7a83117c470d0614008 Signed-off-by: Vladimir Serbinenko Reviewed-on: http://review.coreboot.org/7347 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- src/cpu/intel/fsp_model_206ax/acpi.c | 5 +---- src/cpu/intel/model_2065x/acpi.c | 5 +---- src/cpu/intel/model_206ax/acpi.c | 5 +---- 3 files changed, 3 insertions(+), 12 deletions(-) (limited to 'src/cpu') diff --git a/src/cpu/intel/fsp_model_206ax/acpi.c b/src/cpu/intel/fsp_model_206ax/acpi.c index 57af8366a6..fabf3135cb 100644 --- a/src/cpu/intel/fsp_model_206ax/acpi.c +++ b/src/cpu/intel/fsp_model_206ax/acpi.c @@ -106,10 +106,7 @@ static void generate_C_state_entries(void) if (!cpu || !cpu->cstates) return; - acpigen_emit_byte(0x14); /* MethodOp */ - acpigen_write_len_f(); /* PkgLength */ - acpigen_emit_namestring("_CST"); - acpigen_emit_byte(0x00); /* No Arguments */ + acpigen_write_method("_CST", 0); /* If running on AC power */ acpigen_emit_byte(0xa0); /* IfOp */ diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c index bfe801d587..8d8757ae7a 100644 --- a/src/cpu/intel/model_2065x/acpi.c +++ b/src/cpu/intel/model_2065x/acpi.c @@ -106,10 +106,7 @@ static void generate_C_state_entries(void) if (!cpu || !cpu->cstates) return; - acpigen_emit_byte(0x14); /* MethodOp */ - acpigen_write_len_f(); /* PkgLength */ - acpigen_emit_namestring("_CST"); - acpigen_emit_byte(0x00); /* No Arguments */ + acpigen_write_method("_CST", 0); /* If running on AC power */ acpigen_emit_byte(0xa0); /* IfOp */ diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c index a801ec0928..465525b91e 100644 --- a/src/cpu/intel/model_206ax/acpi.c +++ b/src/cpu/intel/model_206ax/acpi.c @@ -106,10 +106,7 @@ static void generate_C_state_entries(void) if (!cpu || !cpu->cstates) return; - acpigen_emit_byte(0x14); /* MethodOp */ - acpigen_write_len_f(); /* PkgLength */ - acpigen_emit_namestring("_CST"); - acpigen_emit_byte(0x00); /* No Arguments */ + acpigen_write_method("_CST", 0); /* If running on AC power */ acpigen_emit_byte(0xa0); /* IfOp */ -- cgit v1.2.3