From 5dfb3314b436fd5edf6f65112f34d7d8e3f1a162 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Mon, 15 Feb 2021 13:08:43 +0100 Subject: cpu/x86/smm: Move relocatable stub params These stub params need to be synced with the code in smm_stub.S and are consumed by both the smmloader and smmloader_v2. So it is better to have the definition located in one place. Change-Id: Ide3e0cb6dea3359fa9ae660eab627499832817c9 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/50761 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/cpu/x86/smm/smm_module_loader.c | 12 ------------ src/cpu/x86/smm/smm_module_loaderv2.c | 12 ------------ 2 files changed, 24 deletions(-) (limited to 'src/cpu') diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 876fde6733..a4ace43880 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -26,18 +26,6 @@ __attribute__((aligned(16))); * The components are assumed to consist of one consecutive region. */ -/* These parameters are used by the SMM stub code. A pointer to the params - * is also passed to the C-base handler. */ -struct smm_stub_params { - u32 stack_size; - u32 stack_top; - u32 c_handler; - u32 c_handler_arg; - u32 fxsave_area; - u32 fxsave_area_size; - struct smm_runtime runtime; -} __packed; - /* * The stub is the entry point that sets up protected mode and stacks for each * CPU. It then calls into the SMM handler module. It is encoded as an rmodule. diff --git a/src/cpu/x86/smm/smm_module_loaderv2.c b/src/cpu/x86/smm/smm_module_loaderv2.c index cd44f93cc9..8e02fa8316 100644 --- a/src/cpu/x86/smm/smm_module_loaderv2.c +++ b/src/cpu/x86/smm/smm_module_loaderv2.c @@ -27,18 +27,6 @@ __attribute__((aligned(16))); * The components are assumed to consist of one consecutive region. */ -/* These parameters are used by the SMM stub code. A pointer to the params - * is also passed to the C-base handler. */ -struct smm_stub_params { - u32 stack_size; - u32 stack_top; - u32 c_handler; - u32 c_handler_arg; - u32 fxsave_area; - u32 fxsave_area_size; - struct smm_runtime runtime; -} __packed; - /* * The stub is the entry point that sets up protected mode and stacks for each * CPU. It then calls into the SMM handler module. It is encoded as an rmodule. -- cgit v1.2.3