From 151d561dddd99c4e0841789d93f16a7797a7819d Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Fri, 4 Jun 2021 12:11:26 +0200 Subject: cpu/intel/haswell/acpi.c: Do not report P_BLK Even if IO MWAIT redirection were enabled, the base address is wrong. Moreover, the register resource descriptors for all reported C-states use the FFixedHW address space, not I/O. Change-Id: Ic2faaafbe4928994aeeab8098d8e0fb6703d203d Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/55214 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph --- src/cpu/intel/haswell/acpi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'src/cpu') diff --git a/src/cpu/intel/haswell/acpi.c b/src/cpu/intel/haswell/acpi.c index 8eec704003..f20d446b5c 100644 --- a/src/cpu/intel/haswell/acpi.c +++ b/src/cpu/intel/haswell/acpi.c @@ -333,7 +333,7 @@ static void generate_P_state_entries(int core, int cores_per_package) void generate_cpu_entries(const struct device *device) { - int coreID, cpuID, pcontrol_blk = get_pmbase(), plen = 6; + int coreID, cpuID; int totalcores = dev_count_cpu(); int cores_per_package = get_logical_cores_per_package(); int numcpus = totalcores/cores_per_package; @@ -343,15 +343,9 @@ void generate_cpu_entries(const struct device *device) for (cpuID = 1; cpuID <= numcpus; cpuID++) { for (coreID = 1; coreID <= cores_per_package; coreID++) { - if (coreID > 1) { - pcontrol_blk = 0; - plen = 0; - } - /* Generate processor \_SB.CPUx */ acpigen_write_processor( - (cpuID - 1) * cores_per_package+coreID - 1, - pcontrol_blk, plen); + (cpuID - 1) * cores_per_package+coreID - 1, 0, 0); /* Generate P-state tables */ generate_P_state_entries( -- cgit v1.2.3