From d84afd3e61af870e01b5be66530ea5df4469b0c8 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Wed, 13 Nov 2013 16:06:34 -0800 Subject: arm: Remove CAR_MIGRATE Kconfig and associated cruft This is essentially a revert of commit 10bd772d. The CAR_MIGRATE mechanism is only useful to migrate variables from a special region (e.g. cache as RAM) into DRAM-backed CBMEM between different parts of the romstage (it does not persist into ramstage). Since ARM devices use SRAM for which there is no reason to become inaccessible in later parts of the romstage, this mechanism isn't useful for them. Removing it makes the romstage.ld script much simpler, which has the nice side-effect of putting the BSS at the end of the memory image (so that cbfstool can actually figure out that it doesn't need to be part of the ROM image). Old-Change-Id: I50e91d8bd51b5deb19446d9da48699edecbef6ea Signed-off-by: Julius Werner Reviewed-on: https://chromium-review.googlesource.com/176761 Reviewed-by: David Hendricks (cherry picked from commit ebfd698e57c902e2f39a0cfc1bc2b02665e47ec6) console: Make cbmem depend on x86. The cbmem implementation isn't supported on anything other than x86 right now and actually causes memory corruption on ARM machines. Until that's fixed, this will prevent people from turning it on and causing hard to track down errors. Old-Change-Id: I00e8aacf008acfe2f76d4eab82570f7c1cc89cab Signed-off-by: Gabe Black Reviewed-on: https://chromium-review.googlesource.com/191107 Reviewed-by: Julius Werner Commit-Queue: Gabe Black Tested-by: Gabe Black (cherry picked from commit e54f16e346a7f2c66d802fb78a6b24e53b732b83) Squashed two related commits for cbmem support on arm. Change-Id: I2be48cea348ee5dc8ca3632d743500aa111bab08 Signed-off-by: Isaac Christensen Reviewed-on: http://review.coreboot.org/6888 Reviewed-by: Julius Werner Reviewed-by: Edward O'Callaghan Tested-by: build bot (Jenkins) --- src/cpu/x86/Makefile.inc | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/cpu/x86') diff --git a/src/cpu/x86/Makefile.inc b/src/cpu/x86/Makefile.inc index a05c72327f..418b5d7b66 100644 --- a/src/cpu/x86/Makefile.inc +++ b/src/cpu/x86/Makefile.inc @@ -1,5 +1,7 @@ +ifeq ($(CONFIG_ARCH_ROMSTAGE_X86_32),y) romstage-$(CONFIG_EARLY_CBMEM_INIT) += car.c romstage-$(CONFIG_BROKEN_CAR_MIGRATE) += car.c +endif subdirs-$(CONFIG_PARALLEL_MP) += name ramstage-$(CONFIG_PARALLEL_MP) += mp_init.c -- cgit v1.2.3