From 2c3ebd8b9d56c01d8e4adadf6f4e4d5b56cdb4e1 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Fri, 2 Dec 2022 15:38:18 +0200 Subject: mb,sb,soc/intel: Drop useless IO trap handlers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are four requirements for the SMI to hit a printk() this commit now removes. Build must have DEBUG_SMI=y, otherwise any printk() is a no-op inside SMM. ASL must have a TRAP() with argument 0x99 or 0x32 for SMIF value. Platform needs to have IO Trap #3 enabled at IO 0x800. The SMI monitor must call io_trap_handler for IO Trap #3. At the moment, only getac/p470 would meet the above criteria with TRAP(0x32) in its DSDT _INI method. The ASL ignores any return value of TRAP() calls made. A mainboard IO trap handler should have precedence over a southbridge IO trap handler. At the moment we seem to have no cases of the latter to support, so remove the latter. Change-Id: I3a3298c8d9814db8464fbf7444c6e0e6ac6ac008 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/70365 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Arthur Heymans --- src/cpu/x86/smm/smm_module_handler.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/cpu/x86') diff --git a/src/cpu/x86/smm/smm_module_handler.c b/src/cpu/x86/smm/smm_module_handler.c index 32f66af190..a976521e65 100644 --- a/src/cpu/x86/smm/smm_module_handler.c +++ b/src/cpu/x86/smm/smm_module_handler.c @@ -65,9 +65,6 @@ void io_trap_handler(int smif) */ printk(BIOS_DEBUG, "SMI function trap 0x%x: ", smif); - if (southbridge_io_trap_handler(smif)) - return; - if (mainboard_io_trap_handler(smif)) return; -- cgit v1.2.3