From ac0d2ee2de005968b20f421a0ea97edcbea3ea19 Mon Sep 17 00:00:00 2001
From: Arthur Heymans <arthur@aheymans.xyz>
Date: Sun, 9 Aug 2020 15:09:51 +0200
Subject: cpu/x86/smm/smmhandler.c: Get revision using C code

This allows to remove some assembly code.

Tested with QEMU Q35 to still print the revision correctly.

Change-Id: I36fb0e8bb1f46806b11ef8102ce74c0d10fd3927
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44319
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
 src/cpu/x86/smm/smmhandler.S | 10 ----------
 1 file changed, 10 deletions(-)

(limited to 'src/cpu/x86/smm/smmhandler.S')

diff --git a/src/cpu/x86/smm/smmhandler.S b/src/cpu/x86/smm/smmhandler.S
index 1cff23afe6..4cbfbfdfb1 100644
--- a/src/cpu/x86/smm/smmhandler.S
+++ b/src/cpu/x86/smm/smmhandler.S
@@ -165,10 +165,6 @@ untampered_lapic:
 	addl	$SMM_STACK_SIZE, %ebx
 	movl	%ebx, %esp
 
-	/* Get SMM revision */
-	movl	$0xa8000 + 0x7efc, %ebx	/* core 0 address */
-	subl	%ebp, %ebx		/* subtract core X offset */
-
 #if defined(__x86_64__)
 	/* Backup IA32_EFER. Preserves ebx. */
 	movl	$(IA32_EFER), %ecx
@@ -179,13 +175,7 @@ untampered_lapic:
 	/* Enable long mode. Preserves ebx. */
 #include <cpu/x86/64bit/entry64.inc>
 
-	mov	(%ebx), %rdi
-
-#else
-	movl	(%ebx), %eax
-	pushl	%eax
 #endif
-
 	/* Call C handler */
 	call	smi_handler
 
-- 
cgit v1.2.3