From 9d8adc0e3a923e1d201d50344f94a9176e5ec939 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sun, 4 Dec 2016 22:17:37 +0200 Subject: x86 SMM: Fix use with RELOCATABLE_RAMSTAGE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The value for _size was not evaluated correctly if ramstage is relocated, make the calculation runtime. While touching it, move symbol declarations to header file. Change-Id: I4402315945771acf1c86a81cac6d43f1fe99a2a2 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/17784 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/cpu/x86/smm/smm_module_loader.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/cpu/x86/smm/smm_module_loader.c') diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 139bce13ab..b8edf3969e 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -45,9 +45,6 @@ struct smm_stub_params { */ extern unsigned char _binary_smmstub_start[]; -/* This is the SMM handler that the stub calls. It is encoded as an rmodule. */ -extern unsigned char _binary_smm_start[]; - /* Per CPU minimum stack size. */ #define SMM_MINIMUM_STACK_SIZE 32 -- cgit v1.2.3