From e49679d5a1e6a6225980a9ae8455fef47e56ab12 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sat, 8 Jun 2013 15:48:14 +0300 Subject: usbdebug: Drop temporary disables of log output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With this patch, output on usbdebug also includes the section of MTRR setups for every CPU. This makes usbdebug output almost identical with that of serial port and CBMEM console. Tested with model_206ax. Also tested previously on model_f2x which does not have these disable/enable calls in model_f2x_init() without detected issues. Change-Id: Idfd0e93439907b17255633658195d698feab3895 Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/3423 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/cpu/intel/model_2065x/model_2065x_init.c | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'src/cpu/intel/model_2065x') diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c index bdbddfba34..f430276e78 100644 --- a/src/cpu/intel/model_2065x/model_2065x_init.c +++ b/src/cpu/intel/model_2065x/model_2065x_init.c @@ -342,10 +342,6 @@ static void configure_mca(void) wrmsr(IA32_MC0_STATUS + (i * 4), msr); } -#if CONFIG_USBDEBUG -static unsigned ehci_debug_addr; -#endif - /* * Initialize any extra cores/threads in this package. */ @@ -420,12 +416,6 @@ static void model_2065x_init(device_t cpu) fill_processor_name(processor_name); printk(BIOS_INFO, "CPU: %s.\n", processor_name); printk(BIOS_INFO, "CPU:lapic=%ld, boot_cpu=%d\n", lapicid (), boot_cpu ()); -#if CONFIG_USBDEBUG - // Is this caution really needed? - if(!ehci_debug_addr) - ehci_debug_addr = get_ehci_debug(); - set_ehci_debug(0); -#endif /* Setup MTRRs based on physical address size */ cpuid_regs = cpuid(0x80000008); @@ -436,10 +426,6 @@ static void model_2065x_init(device_t cpu) /* Setup Page Attribute Tables (PAT) */ // TODO set up PAT -#if CONFIG_USBDEBUG - set_ehci_debug(ehci_debug_addr); -#endif - /* Enable the local cpu apics */ enable_lapic_tpr(); setup_lapic(); -- cgit v1.2.3