From a02bb653fdfdd0e1c0426d3573a979594a93eb58 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Fri, 5 Feb 2016 14:58:06 -0600 Subject: cpu/intel/microcode: allow microcode to be loaded in romstage The previous usage of the intel microcode support supported using the library under ROMCC and ramstage. Allow for microcode support to be used in normal C-based romstage as well by: 1. Only using walkcbfs when ROMCC is defined. 2. Only using spinlocks if !__PRE_RAM__ The header file now unconditionally exposes the declarations of the supporting functions. Change-Id: I903578bcb4422b4c050903c53b60372b64b79af1 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/13611 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/cpu/intel/microcode/Makefile.inc | 1 + src/cpu/intel/microcode/microcode.c | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) (limited to 'src/cpu/intel/microcode') diff --git a/src/cpu/intel/microcode/Makefile.inc b/src/cpu/intel/microcode/Makefile.inc index 1feb50495a..7452973319 100644 --- a/src/cpu/intel/microcode/Makefile.inc +++ b/src/cpu/intel/microcode/Makefile.inc @@ -3,3 +3,4 @@ ## directly from CBFS. You have been WARNED!!! ################################################################################ ramstage-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c +romstage-$(CONFIG_SUPPORT_CPU_UCODE_IN_CBFS) += microcode.c diff --git a/src/cpu/intel/microcode/microcode.c b/src/cpu/intel/microcode/microcode.c index 35eff160d5..b0681414a1 100644 --- a/src/cpu/intel/microcode/microcode.c +++ b/src/cpu/intel/microcode/microcode.c @@ -19,7 +19,10 @@ #include #include #if !defined(__ROMCC__) +#include #include +#else +#include #endif #include #include @@ -27,11 +30,8 @@ #include #if !defined(__PRE_RAM__) -#include #include DECLARE_SPIN_LOCK(microcode_lock) -#else -#include #endif struct microcode { @@ -121,7 +121,7 @@ const void *intel_microcode_find(void) unsigned int x86_model, x86_family; msr_t msr; -#ifdef __PRE_RAM__ +#ifdef __ROMCC__ struct cbfs_file *microcode_file; microcode_file = walkcbfs_head((char *) MICROCODE_CBFS_FILE); -- cgit v1.2.3