From ba22e159bb21549ba92eb6e9d91eaa097a54985b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Wed, 23 Nov 2016 06:47:15 +0200 Subject: AGESA: Disable CAR with empty stack MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Calling disable_cache_as_ram() with valuables in stack is not a stable solution, as per documentation AMD_DISABLE_STACK should destroy stack in cache. Change-Id: I986bb7a88f53f7f7a0b05d4edcd5020f5dbeb4b7 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/18626 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/cpu/amd/agesa/family12/romstage.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/cpu/amd/agesa/family12') diff --git a/src/cpu/amd/agesa/family12/romstage.c b/src/cpu/amd/agesa/family12/romstage.c index 13b9f06359..8f4e81a9d9 100644 --- a/src/cpu/amd/agesa/family12/romstage.c +++ b/src/cpu/amd/agesa/family12/romstage.c @@ -14,8 +14,6 @@ * GNU General Public License for more details. */ -#include - #include #include @@ -49,8 +47,15 @@ void agesa_main(struct sysinfo *cb) post_code(0x37); agesawrapper_amdinitearly(); + printk(BIOS_INFO, "Normal boot\n"); + post_code(0x38); agesawrapper_amdinitpost(); +} + +void agesa_postcar(struct sysinfo *cb) +{ + printk(BIOS_INFO, "Normal boot postcar\n"); post_code(0x39); printk(BIOS_DEBUG, "sb_before_pci_init "); @@ -59,7 +64,4 @@ void agesa_main(struct sysinfo *cb) post_code(0x40); agesawrapper_amdinitenv(); - - post_code(0x43); - copy_and_run(); } -- cgit v1.2.3