From c36af7b00a9854f626894e51fd28c9df6f1e4e43 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Tue, 18 Nov 2014 12:41:16 +0200 Subject: Replace includes of build.h with version.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As build.h is an auto-generated file it was necessary to add it as an explicit prerequisite in the Makefiles. When this was forgotten abuild would sometimes fail with following error: fatal error: build.h: No such file or directory Fix this error by compiling version.c into all stages. Change-Id: I342f341077cc7496aed279b00baaa957aa2af0db Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/7510 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- src/arch/x86/boot/Makefile.inc | 4 +--- src/arch/x86/boot/smbios.c | 8 ++++---- 2 files changed, 5 insertions(+), 7 deletions(-) (limited to 'src/arch') diff --git a/src/arch/x86/boot/Makefile.inc b/src/arch/x86/boot/Makefile.inc index 2c482b33f3..9a68d81488 100644 --- a/src/arch/x86/boot/Makefile.inc +++ b/src/arch/x86/boot/Makefile.inc @@ -19,6 +19,4 @@ ramstage-$(CONFIG_GENERATE_SMBIOS_TABLES) += smbios.c ramstage-$(CONFIG_HAVE_ACPI_TABLES) += acpigen.c ramstage-$(CONFIG_HAVE_ACPI_RESUME) += wakeup.S -$(obj)/arch/x86/boot/smbios.ramstage.o: $(obj)/build.h - -endif # CONFIG_ARCH_RAMSTAGE_X86_32 \ No newline at end of file +endif # CONFIG_ARCH_RAMSTAGE_X86_32 diff --git a/src/arch/x86/boot/smbios.c b/src/arch/x86/boot/smbios.c index 64889f713c..f2f998d7bc 100644 --- a/src/arch/x86/boot/smbios.c +++ b/src/arch/x86/boot/smbios.c @@ -23,7 +23,7 @@ #include #include #include -#include +#include #include #include #include @@ -123,7 +123,7 @@ const char *__attribute__((weak)) smbios_mainboard_bios_version(void) if (strlen(CONFIG_LOCALVERSION)) return CONFIG_LOCALVERSION; else - return COREBOOT_VERSION; + return coreboot_version; } static int smbios_write_type0(unsigned long *current, int handle) @@ -138,13 +138,13 @@ static int smbios_write_type0(unsigned long *current, int handle) t->vendor = smbios_add_string(t->eos, "coreboot"); #if !CONFIG_CHROMEOS - t->bios_release_date = smbios_add_string(t->eos, COREBOOT_DMI_DATE); + t->bios_release_date = smbios_add_string(t->eos, coreboot_dmi_date); t->bios_version = smbios_add_string(t->eos, smbios_mainboard_bios_version()); #else #define SPACES \ " " - t->bios_release_date = smbios_add_string(t->eos, COREBOOT_DMI_DATE); + t->bios_release_date = smbios_add_string(t->eos, coreboot_dmi_date); u32 version_offset = (u32)smbios_string_table_len(t->eos); t->bios_version = smbios_add_string(t->eos, SPACES); /* SMBIOS offsets start at 1 rather than 0 */ -- cgit v1.2.3