From 1729cd85744129104e3e41aac1f18e43b62f79ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 16 Oct 2014 12:47:25 +0300 Subject: x86 romstage: Move stack just below RAMTOP MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Placement of romstage stack in RAM was vulnerable for getting corrupted by decompressed ramstage. Change-Id: Ic032bd3e69f4ab8dab8e5932df39fab70aa3e769 Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/7096 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/arch/x86/init/crt0_romcc_epilogue.inc | 2 +- src/arch/x86/init/prologue.inc | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'src/arch') diff --git a/src/arch/x86/init/crt0_romcc_epilogue.inc b/src/arch/x86/init/crt0_romcc_epilogue.inc index 419418d64e..791ab8e36a 100644 --- a/src/arch/x86/init/crt0_romcc_epilogue.inc +++ b/src/arch/x86/init/crt0_romcc_epilogue.inc @@ -11,7 +11,7 @@ __main: post_code(POST_PREPARE_RAMSTAGE) cld /* clear direction flag */ - movl $ROMSTAGE_STACK, %esp + movl $CONFIG_RAMTOP, %esp movl %esp, %ebp call copy_and_run diff --git a/src/arch/x86/init/prologue.inc b/src/arch/x86/init/prologue.inc index 84e465c18e..bef42a382f 100644 --- a/src/arch/x86/init/prologue.inc +++ b/src/arch/x86/init/prologue.inc @@ -18,7 +18,6 @@ */ #include -#include .section ".rom.data", "a", @progbits .section ".rom.text", "ax", @progbits -- cgit v1.2.3