From 014c88923aa65916438c15599b473885b98cad0b Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Sat, 29 Aug 2020 08:21:49 +0200 Subject: arch/x86/exit_car.S: Fix checking clflush support The BT instruction stores its result in CF and not ZF so use the correct jump instruction. This fixes a hang in postcar on CPUs lacking support for this instruction. This concerns older pre-SSE2 hardware. Change-Id: I704e3c579150fb9b9a292ef0e83050e7bf7cb078 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/44922 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph Reviewed-by: Paul Menzel --- src/arch/x86/exit_car.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/arch') diff --git a/src/arch/x86/exit_car.S b/src/arch/x86/exit_car.S index dc356b2cf9..fae7899e17 100644 --- a/src/arch/x86/exit_car.S +++ b/src/arch/x86/exit_car.S @@ -59,7 +59,7 @@ _start: movl $1, %eax cpuid btl $CPUID_FEATURE_CLFLUSH_BIT, %edx - jz skip_clflush + jnc skip_clflush clflush _cbmem_top_ptr skip_clflush: -- cgit v1.2.3