From ee8a9f6c5548729cd1e464ccbecfca7a08fcc9a2 Mon Sep 17 00:00:00 2001 From: zbao Date: Tue, 29 May 2012 14:59:38 +0800 Subject: Initializer of a static member in union. It is just me or does anybody have the same build error without this patch? ------ src/arch/x86/boot/acpigen.c: In function 'acpigen_write_empty_PTC': src/arch/x86/boot/acpigen.c:347:3: error: unknown field 'resv' specified in initializer src/arch/x86/boot/acpigen.c:347:3: warning: missing braces around initializer src/arch/x86/boot/acpigen.c:347:3:warning: (near initialization for 'addr.') ------- Anyway, I believe at least this will cause warnings. "resv" is a member of a union, not of acpi_addr_t. So it should be wrapped by a brace in the initializer. Change-Id: I72624386816c987d5bb2d3a3a64c7c58eb9af389 Signed-off-by: Zheng Bao Signed-off-by: zbao Reviewed-on: http://review.coreboot.org/1056 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer Reviewed-by: Marc Jones --- src/arch/x86/boot/acpigen.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/arch/x86') diff --git a/src/arch/x86/boot/acpigen.c b/src/arch/x86/boot/acpigen.c index e7a297d357..71aa10cd17 100644 --- a/src/arch/x86/boot/acpigen.c +++ b/src/arch/x86/boot/acpigen.c @@ -344,7 +344,9 @@ int acpigen_write_empty_PTC(void) .space_id = ACPI_ADDRESS_SPACE_FIXED, .bit_width = 0, .bit_offset = 0, - .resv = 0, + { + .resv = 0 + }, .addrl = 0, .addrh = 0, }; -- cgit v1.2.3