From 6e82ebff73d0a2a9d29248885b30384f1f550376 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Sun, 31 Jan 2021 15:15:11 +0100 Subject: mb/ocp/deltalake: Fill ECC type in romstage Fill the ECC type in `struct memory_info` in romstage, and in SoC code. The SMBIOS override is unnecessary, and this is not mainboard-specific. Change-Id: I8370b3ee7d75914b895946b53923598adf87b522 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/50179 Reviewed-by: Paul Menzel Reviewed-by: Johnny Lin Reviewed-by: Patrick Rudolph Reviewed-by: Jonathan Zhang Tested-by: build bot (Jenkins) --- src/arch/x86/smbios.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'src/arch/x86') diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index bd7f4224ec..33ab1ba3fe 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -443,11 +443,6 @@ static int get_socket_type(void) return 0x02; /* Unknown */ } -unsigned int __weak smbios_memory_error_correction_type(struct memory_info *meminfo) -{ - return meminfo->ecc_type; -} - unsigned int __weak smbios_processor_external_clock(void) { return 0; /* Unknown */ @@ -1023,7 +1018,7 @@ static int smbios_write_type16(unsigned long *current, int *handle) t->location = MEMORY_ARRAY_LOCATION_SYSTEM_BOARD; t->use = MEMORY_ARRAY_USE_SYSTEM; - t->memory_error_correction = smbios_memory_error_correction_type(meminfo); + t->memory_error_correction = meminfo->ecc_type; /* no error information handle available */ t->memory_error_information_handle = 0xFFFE; -- cgit v1.2.3