From 6644d7c508a1a15d5a0c79f47cdf09585c99192f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sun, 6 Jun 2021 08:10:05 +0300 Subject: drivers/generic/ioapic: Drop enable_virtual_wire MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All boards with DRIVERS_GENERIC_IOAPIC select it. Presumably the related configuration of routing IRQ0 when IOAPIC is enabled should be always done to provide i8259 legacy compatibility for payloads. Change-Id: Ie87816271fa63bba892c8615aa5e72ee68f6ba93 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/55287 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Nico Huber --- src/arch/x86/include/arch/ioapic.h | 1 - src/arch/x86/ioapic.c | 12 ++---------- 2 files changed, 2 insertions(+), 11 deletions(-) (limited to 'src/arch/x86') diff --git a/src/arch/x86/include/arch/ioapic.h b/src/arch/x86/include/arch/ioapic.h index 372cb79e9f..99536d4dfd 100644 --- a/src/arch/x86/include/arch/ioapic.h +++ b/src/arch/x86/include/arch/ioapic.h @@ -35,7 +35,6 @@ void setup_ioapic(void *ioapic_base, u8 ioapic_id); void clear_ioapic(void *ioapic_base); void ioapic_set_boot_config(void *ioapic_base, bool irq_on_fsb); -void setup_ioapic_helper(void *ioapic_base, u8 ioapic_id, bool enable_virtual_wire); #endif #endif diff --git a/src/arch/x86/ioapic.c b/src/arch/x86/ioapic.c index a11e5dd9b3..61fed890d1 100644 --- a/src/arch/x86/ioapic.c +++ b/src/arch/x86/ioapic.c @@ -136,17 +136,9 @@ void ioapic_set_boot_config(void *ioapic_base, bool irq_on_fsb) } } -void setup_ioapic_helper(void *ioapic_base, u8 ioapic_id, bool enable_virtual_wire) +void setup_ioapic(void *ioapic_base, u8 ioapic_id) { set_ioapic_id(ioapic_base, ioapic_id); clear_ioapic(ioapic_base); - - if (enable_virtual_wire) - route_i8259_irq0(ioapic_base); -} - - -void setup_ioapic(void *ioapic_base, u8 ioapic_id) -{ - setup_ioapic_helper(ioapic_base, ioapic_id, true); + route_i8259_irq0(ioapic_base); } -- cgit v1.2.3