From 024b13d07c6dcef7acefc3b69c16c46be431fb82 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Thu, 16 Mar 2017 13:41:11 -0700 Subject: arch/x86: Fix space issues detected by checkpatch Fix the following errors and warnings detected by checkpatch.pl: ERROR: space required before the open parenthesis '(' ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open square bracket '[' ERROR: space required after that ',' (ctx:VxV) ERROR: space prohibited before that ',' (ctx:WxW) ERROR: space required after that ';' (ctx:VxV) ERROR: spaces required around that ':' (ctx:ExV) ERROR: spaces required around that ':' (ctx:VxW) ERROR: spaces required around that ':' (ctx:WxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '+=' (ctx:VxV) ERROR: spaces required around that '<=' (ctx:WxV) ERROR: spaces required around that '||' (ctx:VxW) ERROR: space prohibited before that '++' (ctx:WxO) ERROR: need consistent spacing around '+' (ctx:WxV) ERROR: spaces required around that '<' (ctx:WxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: need consistent spacing around '>>' (ctx:WxV) ERROR: "(foo*)" should be "(foo *)" ERROR: "foo* bar" should be "foo *bar" ERROR: "foo * bar" should be "foo *bar" ERROR: code indent should use tabs where possible WARNING: space prohibited between function name and open parenthesis '(' WARNING: unnecessary whitespace before a quoted newline WARNING: please, no spaces at the start of a line WARNING: please, no space before tabs WARNING: Unnecessary space before function pointer arguments TEST=Build and run on Galileo Gen2 Change-Id: I2d7e1a329c6b2e8ca9633a97b595566544d7fd33 Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18862 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/arch/x86/pirq_routing.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to 'src/arch/x86/pirq_routing.c') diff --git a/src/arch/x86/pirq_routing.c b/src/arch/x86/pirq_routing.c index e534a0656b..e844513b49 100644 --- a/src/arch/x86/pirq_routing.c +++ b/src/arch/x86/pirq_routing.c @@ -23,7 +23,7 @@ static void check_pirq_routing_table(struct irq_routing_table *rt) { uint8_t *addr = (uint8_t *)rt; - uint8_t sum=0; + uint8_t sum = 0; int i; printk(BIOS_INFO, "Checking Interrupt Routing Table consistency...\n"); @@ -33,7 +33,7 @@ static void check_pirq_routing_table(struct irq_routing_table *rt) (unsigned int) sizeof(struct irq_routing_table), rt->size ); - rt->size=sizeof(struct irq_routing_table); + rt->size = sizeof(struct irq_routing_table); } for (i = 0; i < rt->size; i++) @@ -52,13 +52,13 @@ static void check_pirq_routing_table(struct irq_routing_table *rt) } if (rt->signature != PIRQ_SIGNATURE || rt->version != PIRQ_VERSION || - rt->size % 16 ) { + rt->size % 16) { printk(BIOS_WARNING, "Interrupt Routing Table not valid.\n"); return; } sum = 0; - for (i=0; isize; i++) + for (i = 0; i < rt->size; i++) sum += addr[i]; /* We're manually fixing the checksum above. This warning can probably @@ -78,8 +78,8 @@ static int verify_copy_pirq_routing_table(unsigned long addr, const struct irq_r int i; uint8_t *rt_orig, *rt_curr; - rt_curr = (uint8_t*)addr; - rt_orig = (uint8_t*)routing_table; + rt_curr = (uint8_t *)addr; + rt_orig = (uint8_t *)routing_table; printk(BIOS_INFO, "Verifying copy of Interrupt Routing Table at 0x%08lx... ", addr); for (i = 0; i < routing_table->size; i++) { if (*(rt_curr + i) != *(rt_orig + i)) { @@ -96,7 +96,7 @@ static int verify_copy_pirq_routing_table(unsigned long addr, const struct irq_r #endif #if CONFIG_PIRQ_ROUTE -static u8 pirq_get_next_free_irq(u8* pirq, u16 bitmap) +static u8 pirq_get_next_free_irq(u8 *pirq, u16 bitmap) { int i, link; u8 irq = 0; @@ -152,7 +152,7 @@ static void pirq_route_irqs(unsigned long addr) printk(BIOS_DEBUG, "INT: %c link: %x bitmap: %x ", 'A' + intx, link, bitmap); - if (!bitmap|| !link || link > CONFIG_MAX_PIRQ_LINKS) { + if (!bitmap || !link || link > CONFIG_MAX_PIRQ_LINKS) { printk(BIOS_DEBUG, "not routed\n"); irq_slot[intx] = irq; -- cgit v1.2.3