From 35382a6eeb6634c291ffb67a3c4fa7a4601a7328 Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Wed, 2 Apr 2014 17:57:05 -0700 Subject: cbmem console: Locate the preram console with a symbol instead of a section. On non-x86 systems, the location of the preram CBMEM console may not be in a predictable place relative to other things in the linker script. That makes it difficult to work with as its own section because the linker will complain if you try to move backwards as it lays out memory. If the console header is treated as an actual blob of memory which has to be put in the image, we'd have to predict where to put it so that it isn't before something with a lower address or after something with a higher address. Symbols, on the other hand, can be defined arbitrarily. Change-Id: I3257b981eee0c15bb997a9f2c55a03494c6ec6f0 Signed-off-by: Gabe Black Reviewed-on: https://chromium-review.googlesource.com/193164 Reviewed-by: Tom Warren Reviewed-by: Aaron Durbin Commit-Queue: Gabe Black Tested-by: Gabe Black (cherry picked from commit a492761c27076bcac080013d509ae4aafd6dc3e3) Signed-off-by: Isaac Christensen Reviewed-on: http://review.coreboot.org/7013 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/arch/x86/include/arch/early_variables.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/arch/x86/include') diff --git a/src/arch/x86/include/arch/early_variables.h b/src/arch/x86/include/arch/early_variables.h index ea1a133ae0..80e82d6408 100644 --- a/src/arch/x86/include/arch/early_variables.h +++ b/src/arch/x86/include/arch/early_variables.h @@ -26,10 +26,8 @@ asm(".previous"); asm(".section .car.cbmem_console,\"w\",@nobits"); asm(".previous"); #define CAR_GLOBAL __attribute__((section(".car.global_data"))) -#define CAR_CBMEM __attribute__((section(".car.cbmem_console"))) #else #define CAR_GLOBAL -#define CAR_CBMEM #endif #if defined(__PRE_RAM__) -- cgit v1.2.3