From 0b5678f21f17024b4f7f6bd67d0d382481751d86 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Thu, 16 Mar 2017 16:01:40 -0700 Subject: arch/x86: Fix most of remaining issues detected by checkpatch Fix the following errors and warnings detected by checkpatch.pl: ERROR: do not use assignment in if condition ERROR: trailing statements should be on next line ERROR: Macros with complex values should be enclosed in parentheses ERROR: switch and case should be at the same indent WARNING: char * array declaration might be better as static const WARNING: else is not generally useful after a break or return WARNING: storage class should be at the beginning of the declaration WARNING: void function return statements are not generally useful WARNING: break is not useful after a goto or return WARNING: Single statement macros should not use a do {} while (0) loop WARNING: sizeof *t should be sizeof(*t) WARNING: Comparisons should place the constant on the right side of the test TEST=Build and run on Galileo Gen2 Change-Id: I39d49790c5eaeedec5051e1fab0b1279275f6e7f Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18865 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/arch/x86/exception.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/arch/x86/exception.c') diff --git a/src/arch/x86/exception.c b/src/arch/x86/exception.c index b8b0f3f023..9121738090 100644 --- a/src/arch/x86/exception.c +++ b/src/arch/x86/exception.c @@ -286,7 +286,6 @@ static void copy_to_hex(char *buf, void *addr, unsigned long count) *buf++ = hexchars[ch & 0x0f]; } *buf = 0; - return; } @@ -319,7 +318,8 @@ static int get_packet(char *buffer) /* wait around for the start character, ignore all other * characters */ - while ((ch = (stub_getc() & 0x7f)) != '$'); + while ((ch = (stub_getc() & 0x7f)) != '$') + ; checksum = 0; xmitcsum = -1; @@ -470,7 +470,6 @@ void x86_exception(struct eregs *info) if (in_buffer[0] == 's') info->eflags |= (1 << 8); return; - break; case 'D': memcpy(out_buffer, "OK", 3); break; -- cgit v1.2.3