From 8fa8f4bdc341d3249aec5fda87f80417cb8917b3 Mon Sep 17 00:00:00 2001 From: Ionela Voinescu Date: Mon, 1 Dec 2014 18:31:48 +0000 Subject: arch/mips: provide proper cache primitives This provides the opportunity to remove the kludge of disabling caches altogether in the bootblock. [pg: originally, this commit also provided automatic cache management after loading stages, ie. flush dcache, so code ends up in icache. This is done differently in upstream, so it's left out here] BUG=chrome-os-partner:34127, chrome-os-partner:31438 TEST=with this fix romstage, ramstage and payload are executed properly BRANCH=none Change-Id: I568c68d02b2cd9c1c2c9c1495ba3343c82509ccc Signed-off-by: Patrick Georgi Original-Commit-Id: 95ab0f159cabf21fc100f371d451211e7d113761 Original-Change-Id: Iaf90b052073dd355ab9114e8dba9f5ef76188c94 Original-Signed-off-by: Ionela Voinescu Original-Reviewed-on: https://chromium-review.googlesource.com/232410 Original-Reviewed-by: Aaron Durbin Reviewed-on: http://review.coreboot.org/9618 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/arch/mips/bootblock.S | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'src/arch/mips/bootblock.S') diff --git a/src/arch/mips/bootblock.S b/src/arch/mips/bootblock.S index ed31b24cfa..8899fe0a97 100644 --- a/src/arch/mips/bootblock.S +++ b/src/arch/mips/bootblock.S @@ -36,16 +36,6 @@ _start: bne $t0, $t1, 1b addi $t0, $t0, 4 - /* - * Disable caches for now, proper cache management is coming soon. - * http://crosbug.com/p/34127 - */ - mfc0 $t0, $16 - li $t1, -8 - and $t0, $t0, $t1 - ori $t0, $t0, 2 - mtc0 $t0, $16 - /* Run main */ b main -- cgit v1.2.3