From 091532d8ee34116e0a8c5a7775f971ada895c4c9 Mon Sep 17 00:00:00 2001 From: John Zhao Date: Sat, 17 Apr 2021 16:03:21 -0700 Subject: ACPI: Fix the devices scope in the SATC structure This change adds the ATC_REQUIRED flag for the address translation cache indicator and fixes the devices scope entry in the SATC reporting structure. The SoC integrated devices in the specified PCI segment with address translation caches are a type of PCI Endpoint Device. BUG=None TEST=Built image successfully. Signed-off-by: John Zhao Change-Id: I57b3551f11502da48f3951da59d9426df5a40723 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52479 Tested-by: build bot (Jenkins) Reviewed-by: Lance Zhao Reviewed-by: Nico Huber --- src/acpi/acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/acpi') diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index b350bc389e..64af505941 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -638,17 +638,15 @@ unsigned long acpi_create_dmar_andd(unsigned long current, u8 device_number, return andd->length; } -unsigned long acpi_create_dmar_satc(unsigned long current, u8 flags, - u16 segment, const char *device_scope) +unsigned long acpi_create_dmar_satc(unsigned long current, u8 flags, u16 segment) { dmar_satc_entry_t *satc = (dmar_satc_entry_t *)current; - int satc_len = sizeof(dmar_satc_entry_t) + strlen(device_scope) + 1; + int satc_len = sizeof(dmar_satc_entry_t); memset(satc, 0, satc_len); satc->type = DMAR_SATC; satc->length = satc_len; satc->flags = flags; satc->segment_number = segment; - memcpy(&satc->device_scope, device_scope, strlen(device_scope)); return satc->length; } -- cgit v1.2.3