From deb2cb27e9bade18c4d186899edfaeabfc1131bd Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Fri, 28 Mar 2014 23:46:45 +0200 Subject: Static CBMEM / CAR: Flag boards with BROKEN_CAR_MIGRATE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use of CAR_GLOBAL is not safe after CAR is torn down, unless the board properly implements EARLY_CBMEM_INIT. Flag vulnerable boards that only do cbmem_recovery() in romstage on S3 resume and implementation with Intel FSP that invalidates cache before we have a chance to copy the contents. Change-Id: Iecd10dee9b73ab3f1f66826950fa0945675ff39f Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/5419 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/Kconfig') diff --git a/src/Kconfig b/src/Kconfig index 531a8c860b..fe7dc9b017 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -170,6 +170,15 @@ config EARLY_CBMEM_INIT some, for instance, execution timestamps. It needs support in romstage.c and should be enabled by the board's Kconfig. +config BROKEN_CAR_MIGRATE + bool + default y if !EARLY_CBMEM_INIT && HAVE_ACPI_RESUME + default n + help + Many boards use CAR_GLOBAL but have no EARLY_CBMEM_INIT and + manage CAR migration on S3 resume path only. Couple boards use + CAR_GLOBAL and never do CAR migration. + config DYNAMIC_CBMEM bool "The CBMEM space is dynamically grown." default n -- cgit v1.2.3