From c4d77128c515e51b907877505a05cf50e254465c Mon Sep 17 00:00:00 2001 From: Robert Zieba Date: Tue, 23 Aug 2022 14:14:16 -0600 Subject: util/spd_tools: Add support for LP5X SPDs This commit adds support for LP5X SPDs. The SPD format is identical to LP5 except that the memory type is set to 0x15 instead of 0x13. Since they are essentially the same, LP5/5X parts share the same parts JSON file and SPD directory. LP5X parts are distinguished by the optional `lp5x` attribute. This commit also updates two existing LP5X memory parts with the correct attribute. BUG=b:242765117 TEST=Generated SPDs, verified that SPDs generated from LP5X parts match their LP5 counterparts except for memory type byte. Signed-off-by: Robert Zieba Change-Id: I67df22bc3fd8ea45fe4dad16b8579351eb4d0d8b Reviewed-on: https://review.coreboot.org/c/coreboot/+/66839 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian Reviewed-by: Caveh Jalali --- spd/lp5/memory_parts.json | 6 ++++-- spd/lp5/platforms_manifest.generated.txt | 2 +- spd/lp5/set-1/spd-7.hex | 2 +- spd/lp5/set-1/spd-8.hex | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) (limited to 'spd/lp5') diff --git a/spd/lp5/memory_parts.json b/spd/lp5/memory_parts.json index 66f32710ae..e371d86669 100644 --- a/spd/lp5/memory_parts.json +++ b/spd/lp5/memory_parts.json @@ -107,7 +107,8 @@ "diesPerPackage": 2, "bitWidthPerChannel": 16, "ranksPerChannel": 1, - "speedMbps": 7500 + "speedMbps": 7500, + "lp5x": true } }, { @@ -117,7 +118,8 @@ "diesPerPackage": 4, "bitWidthPerChannel": 16, "ranksPerChannel": 2, - "speedMbps": 7500 + "speedMbps": 7500, + "lp5x": true } } ] diff --git a/spd/lp5/platforms_manifest.generated.txt b/spd/lp5/platforms_manifest.generated.txt index b3b574e02d..b971e66491 100644 --- a/spd/lp5/platforms_manifest.generated.txt +++ b/spd/lp5/platforms_manifest.generated.txt @@ -3,4 +3,4 @@ MTL,set-0 ADL,set-0 -SBR,set-1 +MDN,set-1 diff --git a/spd/lp5/set-1/spd-7.hex b/spd/lp5/set-1/spd-7.hex index a38dbbd4e9..8b18d495d6 100644 --- a/spd/lp5/set-1/spd-7.hex +++ b/spd/lp5/set-1/spd-7.hex @@ -1,4 +1,4 @@ -23 11 13 0E 86 21 95 18 00 40 00 00 02 02 00 00 +23 11 15 0E 86 21 95 18 00 40 00 00 02 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/spd/lp5/set-1/spd-8.hex b/spd/lp5/set-1/spd-8.hex index e08c69559d..0602fefe62 100644 --- a/spd/lp5/set-1/spd-8.hex +++ b/spd/lp5/set-1/spd-8.hex @@ -1,4 +1,4 @@ -23 11 13 0E 86 21 B5 18 00 40 00 00 0A 02 00 00 +23 11 15 0E 86 21 B5 18 00 40 00 00 0A 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 C0 08 60 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- cgit v1.2.3