From 9760264a96b19e4cd35ad70d92c0db11a3813b67 Mon Sep 17 00:00:00 2001 From: Jakub Czapiga Date: Fri, 18 Mar 2022 14:13:29 +0100 Subject: commonlib/bsd/helpers: Remove redundancy with libpayload defines Move STRINGIFY() from coreboot string.h to commonlib/bsd/helpers.h Remove redundant defines from libpayload.h and libpayloads' standard headers. Signed-off-by: Jakub Czapiga Change-Id: I3263b2aa7657759207bf6ffda750d839e741f99c Reviewed-on: https://review.coreboot.org/c/coreboot/+/62921 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Julius Werner --- payloads/libpayload/drivers/video/graphics.c | 1 - payloads/libpayload/include/libpayload.h | 26 +------------------------- payloads/libpayload/include/stddef.h | 17 +---------------- payloads/libpayload/include/stdlib.h | 6 ------ 4 files changed, 2 insertions(+), 48 deletions(-) (limited to 'payloads') diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index 7f08d40ea2..632a283de9 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -57,7 +57,6 @@ static const struct cb_framebuffer *fbinfo; #define PIVOT_H_MASK (PIVOT_H_LEFT|PIVOT_H_CENTER|PIVOT_H_RIGHT) #define PIVOT_V_MASK (PIVOT_V_TOP|PIVOT_V_CENTER|PIVOT_V_BOTTOM) #define ROUNDUP(x, y) ((((x) + ((y) - 1)) / (y)) * (y)) -#define ABS(x) ((x) < 0 ? -(x) : (x)) static char initialized = 0; diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 90aeeeba0a..24c48c1854 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -46,6 +46,7 @@ #include #include #include +#include #include #include #include @@ -67,33 +68,8 @@ #include #include -/* Double-evaluation unsafe min/max, for bitfields and outside of functions */ -#define __CMP_UNSAFE(a, b, op) ((a) op (b) ? (a) : (b)) -#define MIN_UNSAFE(a, b) __CMP_UNSAFE(a, b, <) -#define MAX_UNSAFE(a, b) __CMP_UNSAFE(a, b, >) - -#define __CMP_SAFE(a, b, op, var_a, var_b) ({ \ - __TYPEOF_UNLESS_CONST(a, b) var_a = (a); \ - __TYPEOF_UNLESS_CONST(b, a) var_b = (b); \ - var_a op var_b ? var_a : var_b; \ -}) - -#define __CMP(a, b, op) __builtin_choose_expr( \ - __builtin_constant_p(a) && __builtin_constant_p(b), \ - __CMP_UNSAFE(a, b, op), __CMP_SAFE(a, b, op, __TMPNAME, __TMPNAME)) - -#define MIN(a, b) __CMP(a, b, <) -#define MAX(a, b) __CMP(a, b, >) - -#define ARRAY_SIZE(a) (sizeof(a) / sizeof((a)[0])) #define BIT(x) (1ul << (x)) -#define DIV_ROUND_UP(x, y) ({ \ - typeof(x) _div_local_x = (x); \ - typeof(y) _div_local_y = (y); \ - (_div_local_x + _div_local_y - 1) / _div_local_y; \ -}) - static inline u32 div_round_up(u32 n, u32 d) { return (n + d - 1) / d; } #define LITTLE_ENDIAN 1234 diff --git a/payloads/libpayload/include/stddef.h b/payloads/libpayload/include/stddef.h index e1273454c2..fb6ec9bf20 100644 --- a/payloads/libpayload/include/stddef.h +++ b/payloads/libpayload/include/stddef.h @@ -2,6 +2,7 @@ #define _STDDEF_H #include +#include #ifndef __WCHAR_TYPE__ #define __WCHAR_TYPE__ int @@ -22,22 +23,6 @@ typedef __SIZE_TYPE__ size_t; typedef __SIZE_TYPE__ ssize_t; #undef unsigned -#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *) 0)->MEMBER) -#define member_size(TYPE, MEMBER) (sizeof(((TYPE *) 0)->MEMBER)) - -#define check_member(structure, member, offset) _Static_assert( \ - offsetof(struct structure, member) == offset, \ - "`struct " #structure "` offset for `" #member "` is not " #offset) - -/* Standard units. */ -#define KiB (1 << 10) -#define MiB (1 << 20) -#define GiB (1 << 30) - -#define KHz (1000) -#define MHz (1000*KHz) -#define GHz (1000*MHz) - #define NSECS_PER_SEC 1000000000 #define USECS_PER_SEC 1000000 #define MSECS_PER_SEC 1000 diff --git a/payloads/libpayload/include/stdlib.h b/payloads/libpayload/include/stdlib.h index eb014f4533..18f1dca8a4 100644 --- a/payloads/libpayload/include/stdlib.h +++ b/payloads/libpayload/include/stdlib.h @@ -34,12 +34,6 @@ #include #include -#define ALIGN(x,a) __ALIGN_MASK(x,(typeof(x))(a)-1UL) -#define __ALIGN_MASK(x,mask) (((x)+(mask))&~(mask)) -#define ALIGN_UP(x,a) ALIGN((x),(a)) -#define ALIGN_DOWN(x,a) ((x) & ~((typeof(x))(a)-1UL)) -#define IS_ALIGNED(x,a) (((x) & ((typeof(x))(a)-1UL)) == 0) - /** * @defgroup malloc Memory allocation functions * @{ -- cgit v1.2.3