From 6a058904d9fc55975689981cad3d65e84e0501d7 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 4 Jul 2014 18:17:39 +0200 Subject: libpayload: Remove redundant phys_to_virt() from xHCI driver Remove a redundant phys_to_virt() that sneaked in the initialization of PCI xHCI controllers. The use of casts from void* to u32 (and vice versa) prompts for things going wrong here. That will be addressed in a later commit. Change-Id: Ibc71ed6ee7016529c0e3a51559aaec07aaaba315 Signed-off-by: Nico Huber Reviewed-on: http://review.coreboot.org/6243 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan Reviewed-by: Paul Menzel --- payloads/libpayload/drivers/usb/xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'payloads') diff --git a/payloads/libpayload/drivers/usb/xhci.c b/payloads/libpayload/drivers/usb/xhci.c index 6106342e58..d9ac0a490b 100644 --- a/payloads/libpayload/drivers/usb/xhci.c +++ b/payloads/libpayload/drivers/usb/xhci.c @@ -305,7 +305,7 @@ xhci_pci_init (pcidev_t addr) u32 reg_addr; hci_t *controller; - reg_addr = (u32)phys_to_virt(pci_read_config32 (addr, 0x10) & ~0xf); + reg_addr = pci_read_config32 (addr, 0x10) & ~0xf; if (pci_read_config32 (addr, 0x14) > 0) { fatal("We don't do 64bit addressing.\n"); } -- cgit v1.2.3