From 3c6e5dbd70e24592162d5aa5e95a8a6abace4e75 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Tue, 10 Mar 2015 12:58:55 +0100 Subject: libpayload udc: Support legal edge case of GET_CONFIGURATION call I doubt anybody will ask for the configuration and request that 0 bytes be returned, but AFAICS that's legal, so let's support it. Should have no effect on ChipIdea since it knows not to send more data than requested by the host. BRANCH=none BUG=none TEST=none Change-Id: Ibfe57b593015fa5e0381c45ff9e39c3f912b4d4d Signed-off-by: Patrick Georgi Original-Commit-Id: 45555e929d9d07dbb58ecfd18333f26375a0e3d7 Original-Change-Id: I7432772a1812c6f52c2b1688ee4c6f67d02ccf28 Original-Signed-off-by: Patrick Georgi Original-Reviewed-on: https://chromium-review.googlesource.com/258064 Original-Reviewed-by: Furquan Shaikh Reviewed-on: http://review.coreboot.org/9790 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- payloads/libpayload/drivers/udc/udc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'payloads') diff --git a/payloads/libpayload/drivers/udc/udc.c b/payloads/libpayload/drivers/udc/udc.c index 23c319bbe4..e01b4546fe 100644 --- a/payloads/libpayload/drivers/udc/udc.c +++ b/payloads/libpayload/drivers/udc/udc.c @@ -168,9 +168,10 @@ static int setup_ep0(struct usbdev_ctrl *this, dev_req_t *dr) res[0] = this->current_config_id; /* data phase IN */ - this->enqueue_packet(this, 0, 1, res, 1, 0, 1); + this->enqueue_packet(this, 0, 1, res, min(1, dr->wLength), + 0, 1); - // status phase OUT + /* status phase OUT */ this->enqueue_packet(this, 0, 0, NULL, 0, 0, 0); return 1; } else -- cgit v1.2.3