From 2332d29ba94cf3c8c1fa89c153fe33a90365b9d6 Mon Sep 17 00:00:00 2001 From: Thomas Heijligen Date: Thu, 17 Nov 2022 21:43:11 +0100 Subject: libpayload: Fix compiler warnings Following warnings occur when compiling with `i386-elf-gcc (coreboot toolchain v2022-09-18_c8870b1334) 11.2.0` drivers/serial/8250.c:75: [-Werror=unused-variable] Move variable declaration inside the `#if !CONFIG(LP_PL011_SERIAL_CONSOLE)` block drivers/udc/dwc2.c:505: [-Werror=format=] use `%zd` to match type `size_t` Change-Id: Id285c24cba790f181fa203f3117e5df35bed27c4 Signed-off-by: Thomas Heijligen Reviewed-on: https://review.coreboot.org/c/coreboot/+/69764 Reviewed-by: Eric Lai Reviewed-by: Nico Huber Reviewed-by: Felix Singer Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- payloads/libpayload/drivers/serial/8250.c | 2 +- payloads/libpayload/drivers/udc/dwc2.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'payloads') diff --git a/payloads/libpayload/drivers/serial/8250.c b/payloads/libpayload/drivers/serial/8250.c index 1df34c41ea..f3d98a9b79 100644 --- a/payloads/libpayload/drivers/serial/8250.c +++ b/payloads/libpayload/drivers/serial/8250.c @@ -72,9 +72,9 @@ static void serial_write_reg(uint8_t val, int offset) static void serial_hardware_init(int speed, int word_bits, int parity, int stop_bits) { +#if !CONFIG(LP_PL011_SERIAL_CONSOLE) unsigned char reg; -#if !CONFIG(LP_PL011_SERIAL_CONSOLE) /* Disable interrupts. */ serial_write_reg(0, 0x01); diff --git a/payloads/libpayload/drivers/udc/dwc2.c b/payloads/libpayload/drivers/udc/dwc2.c index 65413085da..6c72fbae43 100644 --- a/payloads/libpayload/drivers/udc/dwc2.c +++ b/payloads/libpayload/drivers/udc/dwc2.c @@ -502,7 +502,7 @@ static void complete_ep_transfer(struct usbdev_ctrl *this, int endpoint, } SIMPLEQ_REMOVE_HEAD(&p->eps[endpoint][in_dir].job_queue, queue); - usb_debug("%d-%d: scheduled %zd, now %d bytes\n", endpoint, in_dir, + usb_debug("%d-%d: scheduled %zd, now %zd bytes\n", endpoint, in_dir, job->length, job->xfered_length); if (this->current_config && -- cgit v1.2.3