From 5f7b1164c56f36d70813c87e46c540e1e4aa03fc Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Fri, 19 Jul 2019 17:35:28 -0600 Subject: libpayload: Enable -Wimplicit-fallthrough Add comments to intentional fall throughs and enable the warning. Change-Id: I93e071c4fb139fa6e9cd8a1bfb5800f5f4eac50b Signed-off-by: Jacob Garber Reviewed-on: https://review.coreboot.org/c/coreboot/+/34457 Tested-by: build bot (Jenkins) Reviewed-by: HAOUAS Elyes --- payloads/libpayload/libc/printf.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'payloads/libpayload/libc') diff --git a/payloads/libpayload/libc/printf.c b/payloads/libpayload/libc/printf.c index cb623aa51a..3896f01b86 100644 --- a/payloads/libpayload/libc/printf.c +++ b/payloads/libpayload/libc/printf.c @@ -585,6 +585,7 @@ static int printf_core(const char *fmt, struct printf_spec *ps, va_list ap) /* Integer values */ case 'P': /* pointer */ flags |= __PRINTF_FLAG_BIGCHARS; + /* fall through */ case 'p': flags |= __PRINTF_FLAG_PREFIX; base = 16; @@ -599,10 +600,12 @@ static int printf_core(const char *fmt, struct printf_spec *ps, va_list ap) case 'd': case 'i': flags |= __PRINTF_FLAG_SIGNED; + break; case 'u': break; case 'X': flags |= __PRINTF_FLAG_BIGCHARS; + /* fall through */ case 'x': base = 16; break; -- cgit v1.2.3