From a16029a93d06dc73f7ee2796db7c90b2211ee776 Mon Sep 17 00:00:00 2001 From: Shawn Nematbakhsh Date: Mon, 10 Mar 2014 14:12:29 -0700 Subject: libpayload: usb: Remove generic roothub reset port function The generic roothub reset port function is overly broad and does some things which may be undesirable, such as issuing multiple resets to a port if the reset is deemed to have finished too quickly. Remove the generic function and replace it with a controller-specific function, currently only implemented for xhci. Change-Id: Id46f73ea3341d4d01d2b517c6bf687402022d272 Signed-off-by: Shawn Nematbakhsh Reviewed-on: https://chromium-review.googlesource.com/189495 Reviewed-by: Julius Werner (cherry picked from commit 54e1da075b0106b0a1f736641fa52c39401d349d) Signed-off-by: Isaac Christensen Reviewed-on: http://review.coreboot.org/7001 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- payloads/libpayload/drivers/usb/generic_hub.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'payloads/libpayload/drivers/usb/generic_hub.h') diff --git a/payloads/libpayload/drivers/usb/generic_hub.h b/payloads/libpayload/drivers/usb/generic_hub.h index cd4ebb6616..21536c0ecf 100644 --- a/payloads/libpayload/drivers/usb/generic_hub.h +++ b/payloads/libpayload/drivers/usb/generic_hub.h @@ -72,8 +72,11 @@ typedef struct generic_hub { } generic_hub_t; void generic_hub_destroy(usbdev_t *); +int generic_hub_wait_for_port(usbdev_t *const dev, const int port, + const int wait_for, + int (*const port_op)(usbdev_t *, int), + int timeout_steps, const int step_us); int generic_hub_resetport(usbdev_t *, int port); -int generic_hub_rh_resetport(usbdev_t *, int port); /* root hubs have different timing requirements */ int generic_hub_scanport(usbdev_t *, int port); /* the provided generic_hub_ops struct has to be static */ int generic_hub_init(usbdev_t *, int num_ports, const generic_hub_ops_t *); -- cgit v1.2.3