From feb27dcbf3fc685b070c950a16e8adec958bc1ce Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Wed, 28 Jun 2023 20:09:30 +0200 Subject: acpi: Set checksum for SPCR table This was missed recently when adding the table. Linux complains about the missing checksum, e.g. [ 0.186070] ACPI BIOS Warning (bug): Incorrect checksum in table [SPCR] - 0x00, should be 0x87 (20210730/tbprint-173) Tested with QEMU/Q35, albeit with changes to the special handling for ACPI with QEMU. The warning goes away. Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2 Signed-off-by: Nico Huber Fixes: commit 90464073e4a1 (acpi: Add SPCR table) Reviewed-on: https://review.coreboot.org/c/coreboot/+/76158 Reviewed-by: Arthur Heymans Reviewed-by: Lean Sheng Tan Tested-by: build bot (Jenkins) --- src/acpi/acpi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index e0e72f7753..267a989573 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1866,6 +1866,8 @@ static void acpi_create_spcr(acpi_spcr_t *spcr) spcr->language = 0; spcr->pci_did = 0xffff; spcr->pci_vid = 0xffff; + + header->checksum = acpi_checksum((void *)spcr, header->length); } unsigned long __weak fw_cfg_acpi_tables(unsigned long start) -- cgit v1.2.3