From fd51af6286d939a8308ff65260f0fa7ac948507d Mon Sep 17 00:00:00 2001 From: Zheng Bao Date: Thu, 18 Aug 2022 15:26:39 +0800 Subject: amdfwtool:combo: Move the filling of field "lookup" into function This filling does not need to be done separately. Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823 Signed-off-by: Zheng Bao Reviewed-on: https://review.coreboot.org/c/coreboot/+/66853 Tested-by: build bot (Jenkins) Reviewed-by: Fred Reitberger --- util/amdfwtool/amdfwtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 0d5acee111..19a9438ddc 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -632,8 +632,9 @@ static void fill_dir_header(void *directory, uint32_t count, uint32_t cookie, co switch (cookie) { case PSP2_COOKIE: - /* caller is responsible for lookup mode */ cdir->header.cookie = cookie; + /* lookup mode is hardcoded for now. */ + cdir->header.lookup = 1; cdir->header.num_entries = count; cdir->header.reserved[0] = 0; cdir->header.reserved[1] = 0; @@ -2604,7 +2605,6 @@ int main(int argc, char **argv) combo_dir->entries[0].lvl2_addr = BUFF_TO_RUN_MODE(ctx, pspdir, AMD_ADDR_REL_BIOS); - combo_dir->header.lookup = 1; fill_dir_header(combo_dir, 1, PSP2_COOKIE, &ctx); } -- cgit v1.2.3