From fa21c922c6d963e93db5aeeec77229c4772f33be Mon Sep 17 00:00:00 2001 From: Ricardo Ribalda Date: Thu, 28 Jan 2021 13:17:47 +0000 Subject: Revert "mb/google/hatch/dratini: Describe the privacy_gpio" This reverts commit f41645c34d8b22a3d887abd56138ae794fc2dfa5. In Dragonair, during the MP stage, one of the resistors needed for this functionality has been removed. This results in the privacy-switch not readable back by the system. BUG=b:178458332 Change-Id: I0781f338d5ecd89fccee613fb13ea25c59385625 Signed-off-by: Ricardo Ribalda Reviewed-on: https://review.coreboot.org/c/coreboot/+/50044 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Tim Wawrzynczak Reviewed-by: Angel Pons --- src/mainboard/google/hatch/variants/dratini/gpio.c | 2 -- src/mainboard/google/hatch/variants/dratini/overridetree.cb | 13 ------------- 2 files changed, 15 deletions(-) diff --git a/src/mainboard/google/hatch/variants/dratini/gpio.c b/src/mainboard/google/hatch/variants/dratini/gpio.c index 32591b82bf..712a9185d0 100644 --- a/src/mainboard/google/hatch/variants/dratini/gpio.c +++ b/src/mainboard/google/hatch/variants/dratini/gpio.c @@ -16,8 +16,6 @@ static const struct pad_config gpio_table[] = { PAD_NC(GPP_A19, NONE), /* C12 : FPMCU_PCH_BOOT1 */ PAD_CFG_GPO(GPP_C12, 0, DEEP), - /* D4 : Camera Privacy Status */ - PAD_CFG_GPI_INT(GPP_D4, NONE, PLTRST, EDGE_BOTH), /* F1 : NC */ PAD_NC(GPP_F1, NONE), /* F3 : MEM_STRAP_3 */ diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 3605196c11..6176fc6252 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -72,19 +72,6 @@ chip soc/intel/cannonlake device pci 02.0 on # Integrated Graphics Device register "gfx" = "GMA_DEFAULT_PANEL(0)" end - device pci 14.0 on - chip drivers/usb/acpi - device usb 0.0 on - chip drivers/usb/acpi - # The Linux Kernel does not allow an inverted BOTH_EDGE irq - # So we need to use GpioIO() instead of GpioInt() - # https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt - register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)" - device usb 2.6 on end - end - end - end - end # USB xHCI device pci 15.0 on chip drivers/i2c/generic register "hid" = ""ELAN0000"" -- cgit v1.2.3