From f892d5b7a8bef795a772f6bf8144230bd9840c08 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 2 Sep 2021 20:55:33 +0200 Subject: mb/intel/leafhill,minnow3: remove FSP_M_FILE and FSP_S_FILE override Normally, selecting FSP_USE_REPO will select FSP_FULL_FD which then will configure the proper paths for FSP_M_FILE and FSP_S_FILE. The override in these two boards caused FSP_M_FILE and FSP_S_FILE being empty despite ADD_FSP_BINARIES being selected by FSP_USE_REPO which is an invalid case that needs to be avoided, so remove the board-level override of those two options. Signed-off-by: Felix Held Change-Id: I20c8cebea8327d59f0f33d05b824a74bf2121f4b Reviewed-on: https://review.coreboot.org/c/coreboot/+/57347 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/mainboard/intel/leafhill/Kconfig | 10 ---------- src/mainboard/intel/minnow3/Kconfig | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/src/mainboard/intel/leafhill/Kconfig b/src/mainboard/intel/leafhill/Kconfig index dc2eff6ff3..bf59d00cb3 100644 --- a/src/mainboard/intel/leafhill/Kconfig +++ b/src/mainboard/intel/leafhill/Kconfig @@ -44,16 +44,6 @@ config HAVE_IFD_BIN depends on NEED_IFWI default y -config FSP_M_FILE - string "path to FSP-M.Fv blob" - depends on ADD_FSP_BINARIES - default "" - -config FSP_S_FILE - string "path to FSP-S.Fv blob" - depends on ADD_FSP_BINARIES - default "" - config FSP_S_CBFS string default "fsps.bin" diff --git a/src/mainboard/intel/minnow3/Kconfig b/src/mainboard/intel/minnow3/Kconfig index 41aacdd5c8..13a85913d5 100644 --- a/src/mainboard/intel/minnow3/Kconfig +++ b/src/mainboard/intel/minnow3/Kconfig @@ -44,16 +44,6 @@ config HAVE_IFD_BIN depends on NEED_IFWI default y -config FSP_M_FILE - string "path to FSP-M.Fv blob" - depends on ADD_FSP_BINARIES - default "" - -config FSP_S_FILE - string "path to FSP-S.Fv blob" - depends on ADD_FSP_BINARIES - default "" - config FSP_S_CBFS string default "fsps.bin" -- cgit v1.2.3