From f697fe071aaa8d5e34b726416c5a6e1e6e2991e8 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 8 May 2023 19:38:27 +0200 Subject: mb/google/guybrush: Move selects from Kconfig.name to Kconfig Selects should be done in the Kconfig file instead of Kconfig.name and not mixed over both files. Change-Id: If2c9c52f1e2866082df8e534b1a074639bb62db2 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/75020 Reviewed-by: Martin L Roth Tested-by: build bot (Jenkins) --- src/mainboard/google/guybrush/Kconfig | 10 ++++++++++ src/mainboard/google/guybrush/Kconfig.name | 4 ---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index e66419b627..43fd84881b 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -3,6 +3,16 @@ config BOARD_GOOGLE_BASEBOARD_GUYBRUSH def_bool n +config BOARD_GOOGLE_GUYBRUSH + select BOARD_GOOGLE_BASEBOARD_GUYBRUSH + +config BOARD_GOOGLE_NIPPERKIN + select BOARD_GOOGLE_BASEBOARD_GUYBRUSH + select DRIVERS_GFX_GENERIC + +config BOARD_GOOGLE_DEWATT + select BOARD_GOOGLE_BASEBOARD_GUYBRUSH + if BOARD_GOOGLE_BASEBOARD_GUYBRUSH config BOARD_SPECIFIC_OPTIONS diff --git a/src/mainboard/google/guybrush/Kconfig.name b/src/mainboard/google/guybrush/Kconfig.name index a682c76079..f537ee1bd6 100644 --- a/src/mainboard/google/guybrush/Kconfig.name +++ b/src/mainboard/google/guybrush/Kconfig.name @@ -2,13 +2,9 @@ comment "Guybrush" config BOARD_GOOGLE_GUYBRUSH bool "-> Guybrush" - select BOARD_GOOGLE_BASEBOARD_GUYBRUSH config BOARD_GOOGLE_NIPPERKIN bool "-> Nipperkin" - select BOARD_GOOGLE_BASEBOARD_GUYBRUSH - select DRIVERS_GFX_GENERIC config BOARD_GOOGLE_DEWATT bool "-> Dewatt" - select BOARD_GOOGLE_BASEBOARD_GUYBRUSH -- cgit v1.2.3