From f3ae0f0cfb56aae82ff877ee74b9c8e83aee9ab9 Mon Sep 17 00:00:00 2001 From: JasonNien Date: Mon, 29 Jan 2024 18:11:02 -0600 Subject: mb/google/guybrush: turn off SD ASPM L1.1/L1.2 Turn off SD ASPM L1.1/L1.2 as w/a for wlan DMA resume failure We completed 4 runs for each of the 2 tests - power_idle and power_VideoCall. Here are the averages for both the tests: L1ss disabled SD plugged power idle test: 735.3875 L1ss enabled SD plugged power idle test: 737.2335 L1ss disabled SD plugged power video test: 333.29325 L1ss enabled SD plugged power video test: 333.442 BUG=b:254382832 TEST=test pass over 10k cycles Signed-off-by: Jason Nien Change-Id: I4d903f0f6333ffa18069e42be3c932aeae8013d9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80237 Reviewed-by: Matt DeVillier Reviewed-by: Tim Van Patten Tested-by: build bot (Jenkins) --- src/mainboard/google/guybrush/port_descriptors.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/guybrush/port_descriptors.c b/src/mainboard/google/guybrush/port_descriptors.c index fc6ccb8968..a056a19832 100644 --- a/src/mainboard/google/guybrush/port_descriptors.c +++ b/src/mainboard/google/guybrush/port_descriptors.c @@ -33,8 +33,8 @@ static fsp_dxio_descriptor guybrush_czn_dxio_descriptors[] = { .device_number = PCI_SLOT(SD_DEVFN), .function_number = PCI_FUNC(SD_DEVFN), .link_aspm = ASPM_L1, - .link_aspm_L1_1 = true, - .link_aspm_L1_2 = true, + .link_aspm_L1_1 = false, + .link_aspm_L1_2 = false, .turn_off_unused_lanes = true, .clk_req = CLK_REQ1, .gpio_group_id = GPIO_69, -- cgit v1.2.3