From eefa32184c8bc3ccb40fe1693abcae527355d961 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Fri, 4 Dec 2020 08:56:25 +0100 Subject: mb/clevo/cml-u: Move mainboard/gpio.h to variant/gpio.h MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Move mainboard/gpio.h to variant/gpio.h and rename its methods to make clear that these methods are implemented on variant level. Change-Id: I1ae9b54ed683000f65323b11747ce3280a1c7f2a Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/48296 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) --- src/mainboard/clevo/cml-u/bootblock.c | 4 ++-- src/mainboard/clevo/cml-u/include/mainboard/gpio.h | 9 --------- src/mainboard/clevo/cml-u/include/variant/gpio.h | 9 +++++++++ src/mainboard/clevo/cml-u/ramstage.c | 4 ++-- src/mainboard/clevo/cml-u/variants/l140cu/gpio.c | 4 ++-- src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c | 4 ++-- 6 files changed, 17 insertions(+), 17 deletions(-) delete mode 100644 src/mainboard/clevo/cml-u/include/mainboard/gpio.h create mode 100644 src/mainboard/clevo/cml-u/include/variant/gpio.h diff --git a/src/mainboard/clevo/cml-u/bootblock.c b/src/mainboard/clevo/cml-u/bootblock.c index d75158cd1f..389a7a986d 100644 --- a/src/mainboard/clevo/cml-u/bootblock.c +++ b/src/mainboard/clevo/cml-u/bootblock.c @@ -2,9 +2,9 @@ #include #include -#include +#include void bootblock_mainboard_init(void) { - mainboard_configure_early_gpios(); + variant_configure_early_gpios(); } diff --git a/src/mainboard/clevo/cml-u/include/mainboard/gpio.h b/src/mainboard/clevo/cml-u/include/mainboard/gpio.h deleted file mode 100644 index c6393beebb..0000000000 --- a/src/mainboard/clevo/cml-u/include/mainboard/gpio.h +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#ifndef MAINBOARD_GPIO_H -#define MAINBOARD_GPIO_H - -void mainboard_configure_early_gpios(void); -void mainboard_configure_gpios(void); - -#endif diff --git a/src/mainboard/clevo/cml-u/include/variant/gpio.h b/src/mainboard/clevo/cml-u/include/variant/gpio.h new file mode 100644 index 0000000000..95d576294f --- /dev/null +++ b/src/mainboard/clevo/cml-u/include/variant/gpio.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +void variant_configure_early_gpios(void); +void variant_configure_gpios(void); + +#endif diff --git a/src/mainboard/clevo/cml-u/ramstage.c b/src/mainboard/clevo/cml-u/ramstage.c index 771c6aae7b..8196970d6e 100644 --- a/src/mainboard/clevo/cml-u/ramstage.c +++ b/src/mainboard/clevo/cml-u/ramstage.c @@ -1,11 +1,11 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include -#include +#include static void init_mainboard(void *chip_info) { - mainboard_configure_gpios(); + variant_configure_gpios(); } struct chip_operations mainboard_ops = { diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c b/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c index 475c2d56da..d5744ef3db 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c +++ b/src/mainboard/clevo/cml-u/variants/l140cu/gpio.c @@ -1,8 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include #include #include +#include /* Name format: / */ static const struct pad_config gpio_table[] = { @@ -237,7 +237,7 @@ static const struct pad_config gpio_table[] = { PAD_NC(GPP_H23, UP_20K), }; -void mainboard_configure_gpios(void) +void variant_configure_gpios(void) { gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); } diff --git a/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c b/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c index 274efaf77f..3ea1c81e99 100644 --- a/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c +++ b/src/mainboard/clevo/cml-u/variants/l140cu/gpio_early.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include #include +#include /* Name format: / */ static const struct pad_config early_gpio_table[] = { @@ -11,7 +11,7 @@ static const struct pad_config early_gpio_table[] = { PAD_NC(GPP_C23, UP_20K), }; -void mainboard_configure_early_gpios(void) +void variant_configure_early_gpios(void) { gpio_configure_pads(early_gpio_table, ARRAY_SIZE(early_gpio_table)); } -- cgit v1.2.3