From eca8859133f3c5b0114049c4e88ca600cf9433cd Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Fri, 22 Apr 2022 11:29:46 +0200 Subject: Doc/*/gerrit_guidelines.md: Expand fast-track rule Commits that fix a recently-introduced regression can be submitted early to minimise the impact of said regression. However, it is important that the commit message properly reflects what is being fixed and what commit introduced the issue. Change-Id: Ifd49582ae1cbcfe6ee3816e0658dbd0432801161 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/63780 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- Documentation/contributing/gerrit_guidelines.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/contributing/gerrit_guidelines.md b/Documentation/contributing/gerrit_guidelines.md index 68b5cc43c0..74f79c064c 100644 --- a/Documentation/contributing/gerrit_guidelines.md +++ b/Documentation/contributing/gerrit_guidelines.md @@ -53,7 +53,10 @@ it's implemented, should restart the wait period. a recently-introduced issue (build, boot or OS-level compatibility, not necessarily identified by coreboot.org facilities). Its commit message has to explain what change introduced the problem and the nature of -the problem so that the emergency need becomes apparent. The change +the problem so that the emergency need becomes apparent. Avoid stating +something like "fix build error" in the commit summary, describe what +the commit does instead, just like any other commit. In addition, it is +recommended to reference the commit that introduced the issue. The change itself should be as limited in scope and impact as possible to make it simple to assess the impact. Such a change can be merged early with 3 Code-Review+2. For emergency fixes that affect a single project (SoC, -- cgit v1.2.3