From ea629fa8c4b874fb7cd2d5806893189d700c90be Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Sun, 3 Dec 2017 12:35:47 -0600 Subject: Revert "soc/intel/skylake: Clean up SoC ASL code." This partially reverts commit a7b97510aeb1652fd0006c9b2d10df6568f37e2e. For the internal eMMC to be used by Windows for installation, the CARD device and _RMV methods are required. Without them, Windows does not see/show the eMMC as a valid installation target. TEST: boot google/chell with Tianocore payload and install Windows 10 to the internal eMMC drive. Change-Id: I04819ff16ab4cb0d2ea6e1c7f47179f5dacb7cfd Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/22684 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/soc/intel/skylake/acpi/scs.asl | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/soc/intel/skylake/acpi/scs.asl b/src/soc/intel/skylake/acpi/scs.asl index 235a57e05c..e766fd767f 100644 --- a/src/soc/intel/skylake/acpi/scs.asl +++ b/src/soc/intel/skylake/acpi/scs.asl @@ -101,6 +101,15 @@ Device (EMMC) Or (PMCR, 0x0003, PMCR) Store (PMCR, ^TEMP) } + + Device (CARD) + { + Name (_ADR, 0x00000008) + Method (_RMV, 0, NotSerialized) + { + Return (0) + } + } } #if !IS_ENABLED(CONFIG_EXCLUDE_NATIVE_SD_INTERFACE) @@ -162,5 +171,14 @@ Device (SDXC) ^^PCRO (PID_GPIOCOM3, 0x4e4, 0x00001000) ^^PCRO (PID_GPIOCOM3, 0x4f4, 0x00001000) } + + Device (CARD) + { + Name (_ADR, 0x00000008) + Method (_RMV, 0, NotSerialized) + { + Return (1) + } + } } #endif -- cgit v1.2.3