From e780d980e96ad2778fbd892d407fb06cd358c6b2 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Tue, 26 Jan 2021 19:26:51 +0100 Subject: soc/intel/broadwell: Make `broadwell_init_pre_device` static This small function is only used in one place. Change-Id: Ieccdca60fb7837b6406a6b2fd7ebae86958a1afe Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/49945 Reviewed-by: Arthur Heymans Tested-by: build bot (Jenkins) --- src/soc/intel/broadwell/include/soc/ramstage.h | 2 -- src/soc/intel/broadwell/northbridge.c | 5 +++++ src/soc/intel/broadwell/ramstage.c | 6 ------ 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/src/soc/intel/broadwell/include/soc/ramstage.h b/src/soc/intel/broadwell/include/soc/ramstage.h index 4d057ace11..3900c7339e 100644 --- a/src/soc/intel/broadwell/include/soc/ramstage.h +++ b/src/soc/intel/broadwell/include/soc/ramstage.h @@ -6,8 +6,6 @@ #include #include -void broadwell_init_pre_device(void *chip_info); - #if CONFIG(HAVE_REFCODE_BLOB) void broadwell_run_reference_code(void); #else diff --git a/src/soc/intel/broadwell/northbridge.c b/src/soc/intel/broadwell/northbridge.c index 43fa0816fc..bc2638842a 100644 --- a/src/soc/intel/broadwell/northbridge.c +++ b/src/soc/intel/broadwell/northbridge.c @@ -474,6 +474,11 @@ static void broadwell_enable(struct device *dev) } } +static void broadwell_init_pre_device(void *chip_info) +{ + broadwell_run_reference_code(); +} + struct chip_operations soc_intel_broadwell_ops = { CHIP_NAME("Intel Broadwell") .enable_dev = &broadwell_enable, diff --git a/src/soc/intel/broadwell/ramstage.c b/src/soc/intel/broadwell/ramstage.c index 0078939145..a75bd36c99 100644 --- a/src/soc/intel/broadwell/ramstage.c +++ b/src/soc/intel/broadwell/ramstage.c @@ -9,7 +9,6 @@ #include #include #include -#include #include /* Save bit index for PM1_STS and GPE_STS for ACPI _SWS */ @@ -73,8 +72,3 @@ static void acpi_save_wake_source(void *unused) } BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, acpi_save_wake_source, NULL); - -void broadwell_init_pre_device(void *chip_info) -{ - broadwell_run_reference_code(); -} -- cgit v1.2.3