From e145c2fbe2b2b5df46744882446a9d7a1f323cfa Mon Sep 17 00:00:00 2001 From: CoolStar Date: Thu, 9 Feb 2023 22:44:09 -0800 Subject: acpi/acpigen_dptf: Add pkg return to dptf_write_power_limits() The PPCC method should return the package, but is missing the return statement, leading to DPTF/S0ix to not function properly. Add the required return statement. TEST=build/boot Win11 on google/banshee, verify DPTF, S0ix functional. Change-Id: I051db7d69dd6cdfbb07caf649247ee166c1c74ac Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/72921 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Tim Wawrzynczak Reviewed-by: Felix Singer --- src/acpi/acpigen_dptf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index a4b3b09ba1..a458a5599b 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -400,6 +400,8 @@ void dptf_write_power_limits(const struct dptf_power_limits *limits) dptf_write_scope(DPTF_CPU); acpigen_write_method("PPCC", 0); + acpigen_emit_byte(RETURN_OP); + pkg_count = acpigen_write_package(1); /* 1 for the Revision */ acpigen_write_integer(PPCC_REVISION); /* revision */ -- cgit v1.2.3