From deebd9466f3fab66fe6e5f4ebbbc254c7d1cea0b Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 8 May 2023 10:29:42 +0000 Subject: soc/intel/meteorlake: Apply large cbmem buffer size for FSP debug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch ensures that the PRERAM_CBMEM_CONSOLE_SIZE and CONSOLE_CBMEM_BUFFER_SIZE hold a larger cbmem buffer size to contain the entire FSP debug serial log. The existing implementation was not appropriate, where the larger cbmem size was even applicable for serial AP firmware (w/o FSP debug) image as well. This change is necessary to ensure that the FSP debug serial log is always available, even in cases where the cbmem buffer size is limited. BUG=b:280481298 TEST=Able to build and boot google/rex with non-FSP serial AP image and with FSP serial AP image. Able to see the AP log completely inside the cbmem. Signed-off-by: Subrata Banik Change-Id: Ib35780fd558c8b6d9aa2e17241131ea4a58c2b9c Reviewed-on: https://review.coreboot.org/c/coreboot/+/75030 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Kapil Porwal Reviewed-by: Arthur Heymans --- src/soc/intel/meteorlake/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 7762d5f0ec..ee29b50849 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -301,12 +301,12 @@ config CBFS_SIZE config PRERAM_CBMEM_CONSOLE_SIZE hex - default 0x16000 if CONSOLE_SERIAL + default 0x16000 if BUILDING_WITH_DEBUG_FSP default 0x2000 config CONSOLE_CBMEM_BUFFER_SIZE hex - default 0x100000 if CONSOLE_SERIAL + default 0x100000 if BUILDING_WITH_DEBUG_FSP default 0x40000 config FSP_HEADER_PATH -- cgit v1.2.3