From d6fb425ca69ae3c36e18c4be5c2a44f9b4fbdcf2 Mon Sep 17 00:00:00 2001 From: Petr Cvek Date: Thu, 16 Jun 2022 15:17:50 +0200 Subject: intel/gma: Use bitwise or instead addition for valid bit Page table entries bit 0 is used as "valid". Its value should be set by a bitwise OR and not by an addition. Signed-off-by: Petr Cvek Change-Id: I14467081c8279af4611007a25aefab606c61a058 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65172 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas Reviewed-by: Angel Pons --- src/northbridge/intel/i945/gma.c | 4 ++-- src/northbridge/intel/pineview/gma.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/northbridge/intel/i945/gma.c b/src/northbridge/intel/i945/gma.c index 7f5aa094a1..d99a733773 100644 --- a/src/northbridge/intel/i945/gma.c +++ b/src/northbridge/intel/i945/gma.c @@ -343,7 +343,7 @@ static int intel_gma_init_lvds(struct northbridge_intel_i945_config *conf, for (i = 0; i < (uma_size - 256) / 4; i++) { outl((i << 2) | 1, piobase); - outl(pphysbase + (i << 12) + 1, piobase + 4); + outl((pphysbase + (i << 12)) | 1, piobase + 4); } temp = read32(mmiobase + PGETBL_CTL); @@ -521,7 +521,7 @@ static int intel_gma_init_vga(struct northbridge_intel_i945_config *conf, for (i = 0; i < (uma_size - 256) / 4; i++) { outl((i << 2) | 1, piobase); - outl(pphysbase + (i << 12) + 1, piobase + 4); + outl((pphysbase + (i << 12)) | 1, piobase + 4); } /* Clear interrupts. */ diff --git a/src/northbridge/intel/pineview/gma.c b/src/northbridge/intel/pineview/gma.c index ba6f39c5b4..d68c04ded9 100644 --- a/src/northbridge/intel/pineview/gma.c +++ b/src/northbridge/intel/pineview/gma.c @@ -196,7 +196,7 @@ static void intel_gma_init(const struct northbridge_intel_pineview_config *info, for (i = 0; i < (8192 - 512) / 4; i++) { outl((i << 2) | 1, piobase); - outl(physbase + (i << 12) + 1, piobase + 4); + outl((physbase + (i << 12)) | 1, piobase + 4); } temp = read32(mmio + PGETBL_CTL); -- cgit v1.2.3