From d6656bed832b5cf42e86bac286c3cfa5ba30f16d Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 18 Jul 2023 23:33:40 +0200 Subject: soc/amd/*/root_complex: don't report root complex IOAPIC resource twice Since the per PCI root IOAPIC is now reported as domain MMIO resource and the IVRS code now again probes for the IOAPIC resource on the domain device, the IOAPIC resource doesn't need to be reported as resource of the northbridge PCI device any more. Signed-off-by: Felix Held Change-Id: I8604bd321ec4239076b1be99dca095e47f8b75a7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/76600 Reviewed-by: Eric Lai Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/soc/amd/cezanne/root_complex.c | 3 --- src/soc/amd/glinda/root_complex.c | 3 --- src/soc/amd/mendocino/root_complex.c | 3 --- src/soc/amd/phoenix/root_complex.c | 3 --- src/soc/amd/picasso/root_complex.c | 3 --- 5 files changed, 15 deletions(-) diff --git a/src/soc/amd/cezanne/root_complex.c b/src/soc/amd/cezanne/root_complex.c index 0ddce95a8a..cea3b20dd5 100644 --- a/src/soc/amd/cezanne/root_complex.c +++ b/src/soc/amd/cezanne/root_complex.c @@ -143,9 +143,6 @@ static void read_resources(struct device *dev) mmconf_resource(dev, idx++); - /* GNB IOAPIC resource */ - mmio_range(dev, IOMMU_IOAPIC_IDX, GNB_IO_APIC_ADDR, 0x1000); - /* Reserve fixed IOMMU MMIO region */ mmio_range(dev, idx++, IOMMU_RESERVED_MMIO_BASE, IOMMU_RESERVED_MMIO_SIZE); diff --git a/src/soc/amd/glinda/root_complex.c b/src/soc/amd/glinda/root_complex.c index 86554ace77..3ae7688699 100644 --- a/src/soc/amd/glinda/root_complex.c +++ b/src/soc/amd/glinda/root_complex.c @@ -158,9 +158,6 @@ static void read_resources(struct device *dev) mmconf_resource(dev, idx++); - /* GNB IOAPIC resource */ - mmio_range(dev, IOMMU_IOAPIC_IDX, GNB_IO_APIC_ADDR, 0x1000); - /* Reserve fixed IOMMU MMIO region */ mmio_range(dev, idx++, IOMMU_RESERVED_MMIO_BASE, IOMMU_RESERVED_MMIO_SIZE); diff --git a/src/soc/amd/mendocino/root_complex.c b/src/soc/amd/mendocino/root_complex.c index 6154203e1b..0b3f56e32f 100644 --- a/src/soc/amd/mendocino/root_complex.c +++ b/src/soc/amd/mendocino/root_complex.c @@ -186,9 +186,6 @@ static void read_resources(struct device *dev) mmconf_resource(dev, idx++); - /* GNB IOAPIC resource */ - mmio_range(dev, IOMMU_IOAPIC_IDX, GNB_IO_APIC_ADDR, 0x1000); - /* Reserve fixed IOMMU MMIO region */ mmio_range(dev, idx++, IOMMU_RESERVED_MMIO_BASE, IOMMU_RESERVED_MMIO_SIZE); diff --git a/src/soc/amd/phoenix/root_complex.c b/src/soc/amd/phoenix/root_complex.c index 919487e971..6b1a81e499 100644 --- a/src/soc/amd/phoenix/root_complex.c +++ b/src/soc/amd/phoenix/root_complex.c @@ -158,9 +158,6 @@ static void read_resources(struct device *dev) mmconf_resource(dev, idx++); - /* GNB IOAPIC resource */ - mmio_range(dev, IOMMU_IOAPIC_IDX, GNB_IO_APIC_ADDR, 0x1000); - /* Reserve fixed IOMMU MMIO region */ mmio_range(dev, idx++, IOMMU_RESERVED_MMIO_BASE, IOMMU_RESERVED_MMIO_SIZE); diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 46fc0ca7ec..bfcc86f9c4 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -141,9 +141,6 @@ static void read_resources(struct device *dev) mmconf_resource(dev, idx++); - /* GNB IOAPIC resource */ - mmio_range(dev, IOMMU_IOAPIC_IDX, GNB_IO_APIC_ADDR, 0x1000); - /* Reserve fixed IOMMU MMIO region */ mmio_range(dev, idx++, IOMMU_RESERVED_MMIO_BASE, IOMMU_RESERVED_MMIO_SIZE); -- cgit v1.2.3