From d3799d3326ff6bb8f0ec6c6b5a6afa072be87013 Mon Sep 17 00:00:00 2001 From: Frans Hendriks Date: Mon, 19 Nov 2018 15:04:41 +0100 Subject: soc/drivers/intel/fsp1_1: Always report returned status of FspTempRamInit() Returned status code FspTempRamInit() is not displayed when error occurs. Move the printk() call before the check for status. BUG=NA TEST=Portwell PQ7-M107 Change-Id: Id87e5c765d09f4ab199db9eba07a949b031a709a Signed-off-by: Frans Hendriks Reviewed-on: https://review.coreboot.org/c/29695 Reviewed-by: Patrick Rudolph Reviewed-by: Huang Jin Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/drivers/intel/fsp1_1/bootblock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drivers/intel/fsp1_1/bootblock.c b/src/drivers/intel/fsp1_1/bootblock.c index cf9e134719..ce367f774f 100644 --- a/src/drivers/intel/fsp1_1/bootblock.c +++ b/src/drivers/intel/fsp1_1/bootblock.c @@ -2,6 +2,7 @@ * This file is part of the coreboot project. * * Copyright (C) 2016 Intel Corporation. + * Copryight (C) 2018 Eltan B.V. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -51,8 +52,8 @@ void bootblock_fsp_temp_ram_init(void) fsp_temp_ram_init = (FSP_TEMP_RAM_INIT)(fih->ImageBase + fih->TempRamInitEntryOffset); status = fsp_temp_ram_init(&temp_ram_init_params); + printk(BIOS_DEBUG, "FspTempRamInit returned 0x%08x\n", status); if (status != FSP_SUCCESS) die("FspTempRamInit failed. Giving up."); - printk(BIOS_DEBUG, "FspTempRamInit returned 0x%08x\n", status); } -- cgit v1.2.3