From cb6096d71d40c0d15a0abe18ffad1f47c3e7ebf5 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Wed, 17 Aug 2016 16:16:39 -0700 Subject: intel/apollolake: Skip ITSS configuration in SMM In SMM, gpio configuration could be done to avoid leakage. ITSS configuration is not required when entering sleep. Thus, bail out early from itss configuration if in SMM. BUG=chrome-os-partner:56281 Change-Id: I4d8be0513aa202f001f980bb91986b50b8ed2a5b Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/16242 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel --- src/soc/intel/apollolake/gpio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/soc/intel/apollolake/gpio.c b/src/soc/intel/apollolake/gpio.c index 8b89dfd9a0..8e4ff3ebf4 100644 --- a/src/soc/intel/apollolake/gpio.c +++ b/src/soc/intel/apollolake/gpio.c @@ -72,6 +72,10 @@ static const struct pad_community *gpio_get_community(uint16_t pad) static void gpio_configure_itss(const struct pad_config *cfg, uint16_t port, uint16_t pad_cfg_offset) { + /* No ITSS configuration in SMM. */ + if (ENV_SMM) + return; + int irq; /* Set up ITSS polarity if pad is routed to APIC. -- cgit v1.2.3