From bf2710e8496327a9e9a1f5b4517ae2676ba78612 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Thu, 15 Nov 2018 15:21:48 -0700 Subject: mb/google/sarien: Set SMBIOS mainboard SKU Setting sku_id() is not enough to get a value to show up in the SMBIOS tables, it also needs to be returned as a string for the table creation to consume. This change defines the smbios_mainboard_sku() function and returns a string constant of "sku#" as expected. Change-Id: I03013bab89d53d1eba969c6ffb7e95fcbb315a81 Signed-off-by: Duncan Laurie Reviewed-on: https://review.coreboot.org/29649 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Trent Begin --- src/mainboard/google/sarien/sku.c | 6 ++++++ .../google/sarien/variants/arcada/include/variant/variant.h | 1 + .../google/sarien/variants/sarien/include/variant/variant.h | 1 + 3 files changed, 8 insertions(+) diff --git a/src/mainboard/google/sarien/sku.c b/src/mainboard/google/sarien/sku.c index 9fc61a3316..c064c02ef7 100644 --- a/src/mainboard/google/sarien/sku.c +++ b/src/mainboard/google/sarien/sku.c @@ -14,9 +14,15 @@ */ #include +#include #include uint32_t sku_id(void) { return VARIANT_SKU_ID; } + +const char *smbios_mainboard_sku(void) +{ + return VARIANT_SKU_NAME; +} diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h index f1e551a505..d1284322bb 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/variant.h @@ -18,5 +18,6 @@ /* Arcada is SKU ID 2 */ #define VARIANT_SKU_ID 2 +#define VARIANT_SKU_NAME "sku2" #endif diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h index d0be7fcf22..d36750571a 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/variant.h @@ -18,5 +18,6 @@ /* Sarien is SKU ID 1 */ #define VARIANT_SKU_ID 1 +#define VARIANT_SKU_NAME "sku1" #endif -- cgit v1.2.3