From bd74d561adceab2a02629b7439cdb34f18e41c02 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Tue, 20 Sep 2016 14:16:43 +0200 Subject: buildgcc: Show excessive arguments and bail out Also remove a dead line that checks for unknown options: We already let `getopt` check that. Change-Id: I0e829b266e192757d6e455ee4cc608315bb4b7be Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/16681 Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/crossgcc/buildgcc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 0c0154691d..f96e2cf59e 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -725,11 +725,16 @@ while true ; do -n|--nocolor) shift; \ unset red RED green GREEN blue BLUE cyan CYAN NC;; --) shift; break;; - -*) printf "Invalid option\n\n"; myhelp; exit 1;; *) break;; esac done +if [ $# -gt 0 ]; then + printf "Excessive arguments: $*\n" + myhelp + exit 1 +fi + if [ -n "$PRINTSTABLE" ]; then print_stable exit 0 -- cgit v1.2.3