From b8c3d96daa31522775a89225a63ee1d093634094 Mon Sep 17 00:00:00 2001 From: Tyler Wang Date: Thu, 5 Oct 2023 13:51:20 +0800 Subject: mb/google/rex/var/karis: Set touchscreen power/reset GPIOs correctly The tochscreen isn't powered on yet when the detection is done, it makes touchscren no function. Set touchscreen power and reset GPIOs correctly in romstage and ramstage to make the detect feature works. BUG=b:303130400 TEST=(1) emerge-rex coreboot (2) Test on karis, touchscreen function works Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7 Signed-off-by: Tyler Wang Reviewed-on: https://review.coreboot.org/c/coreboot/+/78254 Reviewed-by: Subrata Banik Reviewed-by: Matt DeVillier Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) --- src/mainboard/google/rex/variants/karis/gpio.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mainboard/google/rex/variants/karis/gpio.c b/src/mainboard/google/rex/variants/karis/gpio.c index 4e5eb68c4c..2a94caee13 100644 --- a/src/mainboard/google/rex/variants/karis/gpio.c +++ b/src/mainboard/google/rex/variants/karis/gpio.c @@ -96,9 +96,9 @@ static const struct pad_config gpio_table[] = { PAD_NC(GPP_B23, NONE), /* GPP_C00 : [] ==> EN_TCHSCR_PWR */ - PAD_CFG_GPO(GPP_C00, 0, DEEP), + PAD_CFG_GPO(GPP_C00, 1, DEEP), /* GPP_C01 : [] ==> SOC_TCHSCR_RST_R_L */ - PAD_CFG_GPO(GPP_C01, 0, DEEP), + PAD_CFG_GPO(GPP_C01, 1, DEEP), /* GPP_C02 : SOC_TCHSCR_SPI_INT_STRAP ==> Component NC */ PAD_NC(GPP_C02, NONE), /* GPP_C03 : [] ==> Test pad. */ @@ -399,6 +399,10 @@ static const struct pad_config romstage_gpio_table[] = { PAD_CFG_GPO(GPP_A20, 0, DEEP), /* GPP_C23 : [] ==> FP_RST_ODL */ PAD_CFG_GPO(GPP_C23, 0, DEEP), + /* GPP_C00 : [] ==> EN_TCHSCR_PWR */ + PAD_CFG_GPO(GPP_C00, 1, DEEP), + /* GPP_C01 : [] ==> SOC_TCHSCR_RST_R_L */ + PAD_CFG_GPO(GPP_C01, 0, DEEP), /* GPP_D02 : Not Connected */ PAD_NC(GPP_D02, NONE), }; -- cgit v1.2.3