From b8c2fcca7358839b46b63951712c9b87dbc69c43 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 26 Jul 2021 20:18:46 +0200 Subject: ec/roda/it8518/acpi: Remove unnecessary assignments Simplify some operations to get rid of unnecessary assignments. Change-Id: I02c93d42ce1de693d5d58fd9a29ccd5bff0f5978 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/56609 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/ec/roda/it8518/acpi/battery.asl | 6 ++---- src/ec/roda/it8518/acpi/ec.asl | 6 ++---- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/ec/roda/it8518/acpi/battery.asl b/src/ec/roda/it8518/acpi/battery.asl index 7180ace088..f164587102 100644 --- a/src/ec/roda/it8518/acpi/battery.asl +++ b/src/ec/roda/it8518/acpi/battery.asl @@ -46,8 +46,7 @@ Device (BAT0) Local0 = 0x0f - Local1 = ECPS - Local1 &= 0x02 + Local1 = ECPS & 0x02 If (Local1 == 0x02) { Local0 = 0x1f @@ -75,8 +74,7 @@ Device (BAT0) { Printf ("-----> BAT0: _BST") - Local0 = B0ST - Local0 &= 0x40 + Local0 = B0ST & 0x40 If (Local0 == 0x40) { If (PWRS == 1) diff --git a/src/ec/roda/it8518/acpi/ec.asl b/src/ec/roda/it8518/acpi/ec.asl index 3b9a38ded1..fc241be8af 100644 --- a/src/ec/roda/it8518/acpi/ec.asl +++ b/src/ec/roda/it8518/acpi/ec.asl @@ -132,8 +132,7 @@ Device (EC0) { Printf ("-----> EC: _Q43") - Local0 = BRIG - Local0 += 1 + Local0 = BRIG + 1 If (Local0 > 0xaa) { Local0 = 0xaa } @@ -148,8 +147,7 @@ Device (EC0) { Printf ("-----> EC: _Q44") - Local0 = BRIG - Local0 -= 1 + Local0 = BRIG - 1 If (Local0 < 0xa0) { Local0 = 0xa0 -- cgit v1.2.3